feat: add three-way ad-hoc filters mode (extra_filters, root query, off)#634
Open
edspc wants to merge 1 commit intoVictoriaMetrics:mainfrom
Open
feat: add three-way ad-hoc filters mode (extra_filters, root query, off)#634edspc wants to merge 1 commit intoVictoriaMetrics:mainfrom
edspc wants to merge 1 commit intoVictoriaMetrics:mainfrom
Conversation
…ff) (VictoriaMetrics#633) Replace the binary "Ad-hoc filters to root query" toggle with a three-option selector so users can disable automatic ad-hoc filter injection entirely. This prevents double-filtering when users manage ad-hoc values through Grafana variable interpolation and avoids silent empty results when filtering on pipe-transformed fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #633
Describe Your Changes
Replace the binary "Ad-hoc filters to root query" toggle with a three-option selector so users can disable automatic ad-hoc filter injection entirely. This prevents double-filtering when users manage ad-hoc values through Grafana variable interpolation and avoids silent empty results when filtering on pipe-transformed fields.
Checklist
The following checks are mandatory:
Summary by cubic
Adds a three-option “Ad‑hoc filters” mode (Extra Filters, Root Query, Off) to replace the old toggle. This lets users disable automatic injection to avoid double-filtering and empty results when using pipes or variable interpolation. Related to #633.
New Features
adHocFiltersModeon queries withextraFilters,rootQuery,off; legacyisApplyExtraFiltersToRootQueryis still honored viaresolveAdHocFiltersMode.extra_filters.expr, clearextraFilters.Migration
Written for commit 911a4e0. Summary will update on new commits.