pr: [Nightly Fix] - Bug - Correct All Status Reports

[jewel-claw]

What

Fix form report totals and counts so the "All" bucket actually includes all submissions instead of falling into the abandoned-payment filter path.

Why

Submission::getTotalCount() and Submission::paymentTotal() both treat a missing $paymentStatus as a filtered case. getFormReport() calls those methods without a status for the top-level summary, so the current "All" report can return incomplete numbers.

Fix

• Only apply the abandoned-payment query branch when the status is explicitly abandoned
• Only add a payment-status filter when a real status value is provided
• Leave the existing abandoned and per-status report behavior unchanged

Confidence

High. This is a narrow logic correction in the report model layer, and the modified file passes php -l.

[greptile-apps]

PR author is not in the allowed authors list.

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)

• includes/Classes/Models/Submission.php

The logic changes in both getTotalCount() and paymentTotal() methods correctly address the issue:

• When $paymentStatus is explicitly 'abandoned', the abandoned query is applied
• When $paymentStatus is any other truthy value, it's filtered by that status
• When $paymentStatus is falsy (no filter), all records are returned - fixing the "All" bucket

---

_{Reviewed by minimax-m2.5-20260211 · 79,611 tokens}