Open
Conversation
Author
|
Could you tag a new version after merging? Thanks! |
stecman
approved these changes
Feb 13, 2018
Contributor
stecman
left a comment
stecman
left a comment
There was a problem hiding this comment.
Looks good.
@shane-garelja - I'll leave this to your team to merge and release. Not sure if you have any plans/preferences around changing to Heyday's SS modules to vendor modules?
|
|
||
| $this->extend('onAfterReorderItems', $list); | ||
|
|
Contributor
There was a problem hiding this comment.
Since you're changing this anyway, can you remove the newline before the closing curly brace?
|
Can you please merge this and release a new version? Thanks. |
|
@bendubuisson is there any chance this can be merged and tagged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for SS4, added namespace, use statements and is now a vendor module!