Develop Bulletin sdk by WazirxDax · Pull Request #1 · WazirX/Bulletin-Android

WazirxDax · 2023-03-23T02:36:04Z

No description provided.

rahul-s · 2023-03-23T05:31:03Z

@@ -0,0 +1,69 @@
+plugins {
+    id 'com.android.application'


This should not be an application. This needs to be configured as a library.
Refer to https://github.com/Codigami/CFAlertDialog/blob/master/cfalertdialog/build.gradle

rahul-s · 2023-03-23T05:31:33Z

+    kapt 'com.github.bumptech.glide:compiler:4.13.2'
+
+
+}


New line. Add this to all the new files.

rahul-s · 2023-03-23T05:33:24Z

+        </activity>
+    </application>
+
+</manifest>


rahul-s · 2023-03-23T05:34:18Z

+        gsonInstance = GsonHelper.gsonInstance
+    }
+
+}


rahul-s · 2023-03-23T05:35:06Z

+import com.bulletin.utilities.GsonHelper
+import com.google.gson.Gson
+
+class BulletinApp : Application() {


Application class is not required for this.
Wherever context is required it needs to be passed in as parameter.

I have same thinking but we need to discuss.

rahul-s · 2023-03-23T05:37:02Z

+        android:theme="@style/Theme.Bulletin"
+        tools:targetApi="31">
+        <activity
+            android:name=".MainActivity"


Rename this activity.
Do not use Launcher category. Should be a default activity.

Then how we can run the project?

rahul-s · 2023-03-23T05:46:36Z

+        return true
+    }
+
+}


rahul-s · 2023-03-23T05:48:25Z

+import com.bulletin.utilities.VersionUtil
+import java.util.*
+
+//object BulletinDataStore {


Remove commented code.

rahul-s · 2023-03-23T05:50:55Z

+import com.example.bulletin.databinding.ActivityMainBinding
+import com.wrx.wazirx.views.bulletin.model.Media
+
+class MainActivity : AppCompatActivity(), FormRecyclerViewAdapter.OnItemClickListener {


Rename this activity to a better name

rahul-s · 2023-03-23T05:53:35Z

+        binding = ActivityMainBinding.inflate(layoutInflater)
+        setContentView(binding.root)
+
+        binding.listView.setBackgroundColor(ThemeUtils.getAttributedColor(R.attr.main_bg_surface_alt, binding.listView.context))


We are using our colors in this library..?
We should be configuring this from the main app right..?

rahul-s · 2023-03-23T06:56:20Z

+    }
+
+    fun setUpItems() : ArrayList<BulletinItem> {
+//        val bulletinItem = PreTitle("text")


Remove commented code

rahul-s · 2023-03-23T07:07:49Z

+
+    fun updateAppearance() {
+
+        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {


Extract this condition into an extension.

rahul-s · 2023-03-23T07:20:02Z

+//        val items = BulletinSdk().showUnseenBulletin(4)
+
+
+        val title = Title("Version " + "1.21","In this update","loreum ipsum loreum ipsum loreum ipsum loreum ipsum loreum ipsum")


Remove the hardcoded data.

rahul-s · 2023-03-23T07:21:48Z

+}
+
+fun Any.saveToStorage(key: Any) {
+//    AppStorageHelper.save(key, this)


Is this method required..?

rahul-s · 2023-03-23T07:23:07Z

+package com.bulletin.extension
+
+
+fun String.isNumeric(): Boolean {


These methods can be combined with StringExtensions.kt

will discuss

rahul-s · 2023-03-23T07:26:05Z

@@ -0,0 +1,79 @@
+package com.bulletin.models
+
+data class BulletPoint(var bullet: Bullet?, var titleText: String?, var subTitleText: String?) : BulletinItem() {


Need to discuss this implementation.

WazirxDax added 11 commits February 27, 2023 18:25

project setup

2dee02e

project structure updated

86315b1

color added

545c213

Font added

9f110ea

Viewholder added

55f80aa

Added baseviewholder

600e58d

VIew holder added

0b1a1b3

extension and viewholder updated

c85c739

update the model

379ea77

remove unwanted code

8feffe8

Few class updated

ef4765d

rahul-s reviewed Mar 23, 2023

View reviewed changes

WazirxDax added 3 commits March 26, 2023 20:16

Added new line

9904590

PR feedback

dbdee01

Bulletin minor fixes

2b0820e

		kapt 'com.github.bumptech.glide:compiler:4.13.2'


		} No newline at end of file


		fun updateAppearance() {

		if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {

		// val items = BulletinSdk().showUnseenBulletin(4)


		val title = Title("Version " + "1.21","In this update","loreum ipsum loreum ipsum loreum ipsum loreum ipsum loreum ipsum")

		package com.bulletin.extension


		fun String.isNumeric(): Boolean {

		@@ -0,0 +1,79 @@
		package com.bulletin.models

		data class BulletPoint(var bullet: Bullet?, var titleText: String?, var subTitleText: String?) : BulletinItem() {

Conversation

WazirxDax commented Mar 23, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants