fix(windows): fixed switch menu staying open on focus loss. - #148
Closed
Farroness wants to merge 1 commit into
Closed
fix(windows): fixed switch menu staying open on focus loss.#148Farroness wants to merge 1 commit into
Farroness wants to merge 1 commit into
Conversation
Contributor
Author
|
Poopy fix, gotta go back to the drawing board. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes switch menu on popout chats not collapsing on focus loss.
Why
The switch menu staying open would cause clickthrough issues.
Closes #
How I tested it
Screenshots
N/A
Backend coordination
N/A
Checklist
Gates (CI enforces all of these):
dotnet build Aetherphone.sln -c Releaseis cleandotnet testpasses (this is where localization lockstep and accent contrast are enforced)async void, no new LINQ outside the allowlisted files, no rawImGuiHelpers.GlobalScale(useUiScale.Current), no hand-formatted clock text (useTimeText.Clock)Strings:
Core/Localization/L.csplus the same key in all nine JSONs undersrc/Aetherphone/Localization/, in this same PRL.csanden.jsonso they do not driftQuality:
/phoneor/phonedev)Windows/Components/widgets,TextStyles, andMetricstokensdocs/still tells the truth