Conversation
fusvEnabled was module-level state that was never reset between calls. If a file ended with an active fusv-disable comment and no matching fusv-enable, every subsequent parse() call in the same process would start with fusvEnabled=false, silently dropping all variables found in the files parsed after it.
node.raws.text is undefined for block-style /* fusv-disable */ comments. node.text is the stable public PostCSS API and works for both inline // and block /* */ comment nodes.
Use node.type === 'decl' and node.type === 'comment' which is the public PostCSS API.
lstat does not follow symlinks, so passing a symlinked directory path to findAsync would throw 'Not a valid directory!' even though the path resolves to a valid directory. stat matches the sync path behavior.
When only one extension is provided, the old code assigned the array
itself (e.g. ['scss']) to options.fileExtensions. This worked because
template literals coerce arrays via .toString(), so `**/*.${['scss']}`
produced `**/*.scss` correctly. Replacing it with extensions[0] makes
the intent explicit and avoids relying on implicit coercion.
The spread pattern was creating a new array on every iteration.
XhmikosR
force-pushed
the
xmr/dev
branch
2 times, most recently
from
May 5, 2026 05:45
d279069 to
8e1f962
Compare
- Pass a fully-prepared options object to main() directly instead of re-reading program.opts() inside main() - Return the main() promise from the action callback so commander handles any rejection cleanly - Drop empty strings from split ignore/ignoreFiles values with filter(Boolean) - Rename variables
XhmikosR
force-pushed
the
xmr/dev
branch
6 times, most recently
from
May 6, 2026 10:01
0b5b7c2 to
dc249d7
Compare
- Use named imports from node:fs and node:fs/promises - Switch arrow functions to named functions - Extract buildGlobPattern() to deduplicate glob pattern construction - Simplify sanitizeDir functions by dropping the redundant path.isAbsolute check since path.resolve handles both cases already - Rename internal identifiers - Drop assertIsDirectory, validateDirAsync and validateDirSync
The ignore and ignoreFiles options have always been trimmed; fileExtensions was not. A leading/trailing space produced a glob like **/*. scss which matched nothing.
XhmikosR
force-pushed
the
xmr/dev
branch
2 times, most recently
from
May 6, 2026 10:39
2b3f8b9 to
87ac5c9
Compare
XhmikosR
marked this pull request as ready for review
May 6, 2026 12:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.