Feat (brevitas_examples/llm): custom trainer support#1474
Open
Giuseppe5 wants to merge 10 commits into
Open
Conversation
Giuseppe5
changed the title
Giuseppe5
force-pushed
the
override_trainer
branch
from
d0777c0 to
2a139ea
Compare
Giuseppe5
force-pushed
the
override_trainer
branch
from
2a139ea to
09c5959
Compare
Giuseppe5
force-pushed
the
override_trainer
branch
from
2b51715 to
fdbaad6
Compare
Giuseppe5
commented
Apr 28, 2026
Giuseppe5
force-pushed
the
override_trainer
branch
from
44d399b to
afca554
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this PR
Currently, our Trainer only supports rotation optimization, with little possibility of customization
Changes Made in this PR
This PR allows to fully override the Trainer, including what parameters to optimize, which loss to use for each different set of parameters, which callback to use, etc.
Testing Summary
Added test with custom class