Skip to content

Fix the E2E job locking itself out with 429 - #250

Open
davifernan wants to merge 1 commit into
ZimengXiong:mainfrom
davifernan:fix/e2e-rate-limit
Open

Fix the E2E job locking itself out with 429#250
davifernan wants to merge 1 commit into
ZimengXiong:mainfrom
davifernan:fix/e2e-rate-limit

Conversation

@davifernan

Copy link
Copy Markdown
Contributor

The E2E job has been failing since late June — on main, on Dependabot PRs, and on anything opened from a fork. 21 of 62 tests fail, 20 of them with:

Error: Failed to fetch CSRF token: 429 {"error":"Rate limit exceeded"}

The suite requests far more than the default 60 CSRF tokens, so the server locks it out partway through.

e2e/playwright.config.ts already accounts for this and raises CSRF_MAX_REQUESTS and RATE_LIMIT_MAX_REQUESTS for the servers it starts — but that block is skipped when CI is set, and the workflow starts the backend itself without them.

Passing the same values in the workflow is the whole change. Measured on a clean main checkout, same suite, same machine, only the limits differ:

result
current settings 21 failed, 41 passed
with the limits raised 62 passed

🤖 Generated with Claude Code

The E2E job has been failing since June. 21 of 62 tests fail, 20 of them
with "Failed to fetch CSRF token: 429 Rate limit exceeded" — the suite
requests far more than the default 60 CSRF tokens and locks itself out.

playwright.config.ts already raises CSRF_MAX_REQUESTS and
RATE_LIMIT_MAX_REQUESTS for the servers it starts, but that block is skipped
when CI is set, and the workflow starts the backend without them.

Passing the same values in the workflow takes a clean main checkout from
21 failed / 41 passed to 62 passed.

Generated by Nilo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant