Skip to content

Harden diagram IR edge rendering#90

Merged
ZimoLiao merged 2 commits intomainfrom
cli/english-messages
Apr 28, 2026
Merged

Harden diagram IR edge rendering#90
ZimoLiao merged 2 commits intomainfrom
cli/english-messages

Conversation

@ZimoLiao
Copy link
Copy Markdown
Owner

What does this PR do?

  • Hardens diagram --from-ir so IR edges using common source / target aliases render correctly alongside the canonical from / to keys.
  • Converts malformed edge schemas into clean ValueError messages instead of raw tracebacks.
  • Adds regression coverage and a changelog entry from the CLI smoke pass.

Type of change

  • Bug fix
  • New feature / skill
  • Refactoring (no behavior change)
  • Documentation
  • CI / tooling

Checklist

  • ruff check passes
  • pytest passes
  • New public API has docstrings (N/A; no new public API)
  • CHANGELOG.md updated (for user-facing changes)

Verification

  • PYTHONDONTWRITEBYTECODE=1 python -m pytest -q -p no:cacheprovider tests/test_diagram.py tests/test_diagram_integration.py tests/test_diagram_fault_injection.py -> 112 passed, 3 skipped
  • PYTHONDONTWRITEBYTECODE=1 python -m pytest -q -p no:cacheprovider -> 1311 passed, 3 skipped
  • PYTHONDONTWRITEBYTECODE=1 python -m ruff check scholaraio/services/diagram.py tests/test_diagram.py -> All checks passed
  • PYTHONDONTWRITEBYTECODE=1 python -m ruff format --check scholaraio/services/diagram.py tests/test_diagram.py -> 2 files already formatted
  • Manual CLI smoke reproduced diagram --from-ir ... --format mermaid with source / target edges successfully.

@ZimoLiao ZimoLiao merged commit da7077a into main Apr 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant