refactor: make set_credentials synchronous in InMemoryContextCredentialStore#1116
Open
odanilosalve wants to merge 6 commits into
Open
refactor: make set_credentials synchronous in InMemoryContextCredentialStore#1116odanilosalve wants to merge 6 commits into
odanilosalve wants to merge 6 commits into
Conversation
…dentials refactor: make set_credentials synchronous in InMemoryContextCredentialStore
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request changes the set_credentials method in src/a2a/client/auth/credentials.py from asynchronous to synchronous. The corresponding test calls in tests/client/test_auth_interceptor.py have been updated to remove the await keyword. No review comments were provided, and I have no additional feedback.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/client/auth/interceptor.py | 85.42% | 80.56% | 🔴 -4.86% |
| src/a2a/client/transports/rest.py | 89.89% | 86.98% | 🔴 -2.91% |
| Total | 92.99% | 92.86% | 🔴 -0.13% |
Generated by coverage-comment.yml
- Suppress S1763 for necessary yield in abstract async generators - Replace generic Exception with A2AError in JsonRpcTransport._create_jsonrpc_error - Reduce cognitive complexity in _parse_rest_error by extracting helpers
…dentials Refactor/remove async set credentials
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary async keyword from InMemoryContextCredentialStore.set_credentials. The method body is purely synchronous (dict operations) and is not part of any ABC interface contract.
Also removes await from the 4 test call sites that used it.