Skip to content

Commit 812a39f

Browse files
authored
Merge pull request #2298 from ably/pubsub-split/rename-references
Update repository references for rename to ably-pubsub-js
2 parents 77ab200 + f4bffa1 commit 812a39f

11 files changed

Lines changed: 25 additions & 25 deletions

File tree

.github/workflows/bundle-report.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
- uses: aws-actions/configure-aws-credentials@67fbcbb121271f7775d2e7715933280b06314838 # v1
3333
with:
3434
aws-region: eu-west-2
35-
role-to-assume: arn:aws:iam::${{ secrets.ABLY_AWS_ACCOUNT_ID_SDK }}:role/ably-sdk-builds-ably-js
35+
role-to-assume: arn:aws:iam::${{ secrets.ABLY_AWS_ACCOUNT_ID_SDK }}:role/ably-sdk-builds-ably-pubsub-js
3636
role-session-name: '${{ github.run_id }}-${{ github.run_number }}'
3737
- uses: ably/sdk-upload-action@8c6179796fc7ee8fc9bb28d5223ffef005b985cc # v1
3838
with:

.github/workflows/docs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jobs:
6060
uses: aws-actions/configure-aws-credentials@67fbcbb121271f7775d2e7715933280b06314838 # v1
6161
with:
6262
aws-region: eu-west-2
63-
role-to-assume: arn:aws:iam::${{ secrets.ABLY_AWS_ACCOUNT_ID_SDK }}:role/ably-sdk-builds-ably-js
63+
role-to-assume: arn:aws:iam::${{ secrets.ABLY_AWS_ACCOUNT_ID_SDK }}:role/ably-sdk-builds-ably-pubsub-js
6464
role-session-name: '${{ github.run_id }}-${{ github.run_number }}'
6565

6666
- name: Upload Documentation

.github/workflows/features.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ jobs:
1414
id-token: write
1515
uses: ably/features/.github/workflows/sdk-features.yml@6b3fc7a8ede2ebdd7a6325314f3a96c6466f1453 # main
1616
with:
17-
repository-name: ably-js
17+
repository-name: ably-pubsub-js
1818
secrets:
1919
ABLY_AWS_ACCOUNT_ID_SDK: ${{ secrets.ABLY_AWS_ACCOUNT_ID_SDK }}

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
.DS_Store
2-
ably-js.iml
2+
ably-pubsub-js.iml
33
.idea
44
node_modules
55
npm-debug.log

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Contributing to ably-js
1+
# Contributing to ably-pubsub-js
22

33
## Contributing
44

@@ -7,7 +7,7 @@
77
3. Create your feature branch (`git checkout -b my-new-feature`)
88
4. Commit your changes (`git commit -am 'Add some feature'`)
99
5. Ensure you have added suitable tests and the test suite is passing(`npm test`)
10-
6. Ensure the [type definitions](https://github.com/ably/ably-js/blob/main/ably.d.ts) have been updated if the public API has changed
10+
6. Ensure the [type definitions](https://github.com/ably/ably-pubsub-js/blob/main/ably.d.ts) have been updated if the public API has changed
1111
7. Push the branch (`git push origin my-new-feature`)
1212
8. Create a new Pull Request
1313

@@ -23,7 +23,7 @@
2323
8. Run `git tag <VERSION_NUMBER>` with the new version and push the tag to GitHub with `git push <REMOTE> <VERSION_NUMBER>` (usually `git push origin <VERSION_NUMBER>`)
2424
9. Run `npm publish .` (should require OTP) - publishes to NPM
2525
10. Run the GitHub action "Publish to CDN" with the new tag name
26-
11. Visit https://github.com/ably/ably-js/tags and create a GitHub release based on the new tag (for release notes, you generally can just copy the notes you added to the CHANGELOG)
26+
11. Visit https://github.com/ably/ably-pubsub-js/tags and create a GitHub release based on the new tag (for release notes, you generally can just copy the notes you added to the CHANGELOG)
2727
12. Update the [Ably Changelog](https://changelog.ably.com/) (via [headwayapp](https://headwayapp.co/)) with these changes (again, you can just copy the notes you added to the CHANGELOG)
2828

2929
## Building the library

README.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
![Ably Chat Header](/images/JavaScriptSDK-github.png)
22
[![npm version](https://img.shields.io/npm/v/ably.svg?style=flat)](https://img.shields.io/npm/v/ably.svg?style=flat)
3-
[![License](https://badgen.net/github/license/ably/ably-js)](https://github.com/ably/ably-js/blob/main/LICENSE)
3+
[![License](https://badgen.net/github/license/ably/ably-pubsub-js)](https://github.com/ably/ably-pubsub-js/blob/main/LICENSE)
44

55
---
66

@@ -35,13 +35,13 @@ Ably aims to support a wide range of platforms and all current browser versions,
3535

3636
The following platforms are supported:
3737

38-
| Platform | Support |
39-
| ----------- | ---------------------------------------------------------------------------------------- |
40-
| JavaScript | ES2017 |
41-
| Node.js | See `engines` in [package.json](https://github.com/ably/ably-js/blob/main/package.json). |
42-
| React | >=16.8.x |
43-
| TypeScript | Type definitions are included in the package. |
44-
| Web Workers | Browser bundle and [modular](#modular-variant) support. |
38+
| Platform | Support |
39+
| ----------- | ----------------------------------------------------------------------------------------------- |
40+
| JavaScript | ES2017 |
41+
| Node.js | See `engines` in [package.json](https://github.com/ably/ably-pubsub-js/blob/main/package.json). |
42+
| React | >=16.8.x |
43+
| TypeScript | Type definitions are included in the package. |
44+
| Web Workers | Browser bundle and [modular](#modular-variant) support. |
4545

4646
> [!NOTE]
4747
> Versions 1.2.x of the SDK support Internet Explorer >=9 and other older browsers, as well as Node.js >=8.17.
@@ -133,7 +133,7 @@ In order to further reduce bundle size, the modular variant of the SDK performs
133133

134134
If you require more verbose logging, use the default variant of the SDK.
135135

136-
For more information view the [TypeDoc references](https://sdk.ably.com/builds/ably/ably-js/main/typedoc/modules/modular.html).
136+
For more information view the [TypeDoc references](https://sdk.ably.com/builds/ably/ably-pubsub-js/main/typedoc/modules/modular.html).
137137

138138
</details>
139139

@@ -147,13 +147,13 @@ Read the [CONTRIBUTING.md](./CONTRIBUTING.md) guidelines to contribute to Ably.
147147

148148
## Releases
149149

150-
The [CHANGELOG.md](/ably/ably-js/blob/main/CHANGELOG.md) contains details of the latest releases for this SDK. You can also view all Ably releases on [changelog.ably.com](https://changelog.ably.com).
150+
The [CHANGELOG.md](/ably/ably-pubsub-js/blob/main/CHANGELOG.md) contains details of the latest releases for this SDK. You can also view all Ably releases on [changelog.ably.com](https://changelog.ably.com).
151151

152152
---
153153

154154
## Support, feedback, and troubleshooting
155155

156-
For help or technical support, visit Ably's [support page](https://ably.com/support) or [GitHub Issues](https://github.com/ably/ably-js-nativescript/issues) for community-reported bugs and discussions.
156+
For help or technical support, visit Ably's [support page](https://ably.com/support) or [GitHub Issues](https://github.com/ably/ably-pubsub-js/issues) for community-reported bugs and discussions.
157157

158158
### Chrome extensions
159159

@@ -221,7 +221,7 @@ export default function AblyClientProvider({ children }) {
221221
}
222222
```
223223

224-
Avoid creating the client inside [React](https://github.com/ably/ably-js/blob/main/docs/react.md#Usage) component bodies, as this leads to a new connection on every render. Use the `useEffect` + `useState` pattern shown above, or move the client to a shared provider at the layout level.
224+
Avoid creating the client inside [React](https://github.com/ably/ably-pubsub-js/blob/main/docs/react.md#Usage) component bodies, as this leads to a new connection on every render. Use the `useEffect` + `useState` pattern shown above, or move the client to a shared provider at the layout level.
225225

226226
In development environments that use Hot Module Replacement (HMR), such as React, Vite, or Next.js, saving a file can recreate the Ably.Realtime client, while previous instances remain connected. Over time, this leads to a growing number of active connections with each code edit. To fix: Move the client to a separate file (e.g., `ably-client.js`) and import it. This ensures the client is recreated only when that file changes.
227227

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"version": "2.28.0",
55
"license": "Apache-2.0",
66
"bugs": {
7-
"url": "https://github.com/ably/ably-js/issues",
7+
"url": "https://github.com/ably/ably-pubsub-js/issues",
88
"email": "support@ably.com"
99
},
1010
"main": "./build/ably-node.js",
@@ -164,7 +164,7 @@
164164
"engines": {
165165
"node": ">=16"
166166
},
167-
"repository": "ably/ably-js",
167+
"repository": "ably/ably-pubsub-js",
168168
"jspm": {
169169
"registry": "npm",
170170
"directories": {

scripts/processPrivateApiData/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { StaticContext } from './staticContext';
55
export function stripFilePrefix(records: Record[]) {
66
for (const record of records) {
77
if (record.context.file !== null) {
8-
record.context.file = record.context.file.replace('/home/runner/work/ably-js/ably-js/', '');
8+
record.context.file = record.context.file.replace('/home/runner/work/ably-pubsub-js/ably-pubsub-js/', '');
99
}
1010
}
1111
}

src/common/lib/util/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -525,7 +525,7 @@ export function createMissingPluginError(pluginName: keyof ModularPlugins): Erro
525525
'Import { LiveObjects } from "ably/liveobjects" and pass it in ClientOptions.plugins: { LiveObjects }.';
526526
break;
527527
default:
528-
remediation = `Import ${pluginName} from "ably/modular" and pass it in ClientOptions.plugins: { ${pluginName} }. See the modular variant reference at https://sdk.ably.com/builds/ably/ably-js/main/typedoc/modules/modular.html.`;
528+
remediation = `Import ${pluginName} from "ably/modular" and pass it in ClientOptions.plugins: { ${pluginName} }. See the modular variant reference at https://sdk.ably.com/builds/ably/ably-pubsub-js/main/typedoc/modules/modular.html.`;
529529
break;
530530
}
531531
const err = new ErrorInfo({

src/fragments/license.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ const { version } = require('../../package.json');
44
module.exports = `@license Copyright 2015-2022 Ably Real-time Ltd (ably.com)
55
66
Ably JavaScript Library v${version}
7-
https://github.com/ably/ably-js
7+
https://github.com/ably/ably-pubsub-js
88
99
Released under the Apache Licence v2.0`;

0 commit comments

Comments
 (0)