fix: update channel push CLI commands to use push publish --channel flag#3310
fix: update channel push CLI commands to use push publish --channel flag#3310
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
You might like to link |
sacOO7
left a comment
There was a problem hiding this comment.
We don't use --channel flag anymore, this was replaced by CHANNEL_NAME as per ably/ably-cli#361. You should check latest ably push docs at https://ably.com/docs/cli/push/publish
There was a problem hiding this comment.
Pull request overview
Updates the Push Notifications getting-started guides to use the newer Ably CLI push publish workflow for sending channel-based pushes, replacing the legacy channels publish example that embedded push extras JSON.
Changes:
- Replace the channel push example command with
ably push publish --channel ...plus--title/--bodyand a JSON payload argument. - Update surrounding instructional text to reflect the new CLI command style.
- Add a “next steps” link intended to point readers to push-related CLI options.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/pages/docs/push/getting-started/web.mdx | Updates the channel push CLI example and adds a link to supposed push CLI command reference. |
| src/pages/docs/push/getting-started/fcm.mdx | Updates the channel push CLI example and adds a link to supposed push CLI command reference. |
| src/pages/docs/push/getting-started/apns.mdx | Updates the channel push CLI example and adds a link to supposed push CLI command reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
I think in the case of |
You are right, seems it's the same way in doc as well as source code. The change was only made to |
sacOO7
left a comment
There was a problem hiding this comment.
It's better to give explicit link to ably cli page since new users will not be aware of it
Replace legacy `ably channels publish` with extras JSON with the new `ably push publish --channel` flag in APNs, FCM, and web push guides. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… add push CLI link to next steps Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
164e355 to
de34a55
Compare
…etting-started guides. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
de34a55 to
511cb72
Compare
Summary
ably channels publishwith inline JSON extras in APNs, FCM, and web push getting-started guidesably push publish --channel <name>flag with--title,--body, and--dataoptionshttps://ably.atlassian.net/browse/DX-927