Skip to content

Add cmake support #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
banshee wants to merge 4 commits into from
Closed

Add cmake support #31

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c43f41e
Add cmake support
banshee Aug 19, 2018
1b6f230
Added #include <errno.h> to files that use errno.
banshee Aug 25, 2018
f89a781
Specify a C++ standard
banshee Aug 25, 2018
4a6fccc
Merge branch 'jmoore_errnofix' into jmoore_cmake
banshee Aug 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ cmake_minimum_required(VERSION 3.6)

project (elfin)

set(CMAKE_CXX_STANDARD 17)

@Smertig Smertig Sep 7, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be 11, not 17

@madebr madebr Oct 23, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD 11)


add_subdirectory(elf elfdir)
add_subdirectory(dwarf dwarfdir)
add_subdirectory(examples examplesdir)
Comment on lines +7 to +9

@madebr madebr Oct 23, 2020 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding an immediate subdirectory in the source tree as a different directory in the build directory is not necessary.
Also, optionally building the examples is nice as they are not needed when e.g. only wanting to build the library or adding libelfin as a subdirectory/subproject.

Suggested change
add_subdirectory(elf elfdir)
add_subdirectory(dwarf dwarfdir)
add_subdirectory(examples examplesdir)
option(BUILD_LIBELFIN_EXAMPLES "Build libelfin examples" ON)
add_subdirectory(elf)
add_subdirectory(dwarf)
if(BUILD_LIBELFIN_EXAMPLES)
add_subdirectory(examples)
endif()