feat: GaussDB plugin support + plugin connectivity timeout (CE) #2758#3292
Merged
Conversation
Add DriverTypeGaussDB = "GaussDB" to the driver type constants in sqle/driver/v2/util.go, enabling the GaussDB audit plugin to register with the SQLE platform. Refs #2758
PR Reviewer Guide 🔍(Review updated until commit 42f9c73)
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
BugsGuru
approved these changes
May 15, 2026
|
Persistent review updated to latest commit 42f9c73 |
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
DriverTypeGaussDB = "GaussDB"insqle/driver/v2/util.goso the new GaussDB audit plugin can be discovered by SQLE.CheckInstanceIsConnectablewith a 60 s total timeout plus a bounded 45 s gRPC deadline onplugin.Init, preventing the data-source connectivity test from hanging indefinitely (observed on Huawei Cloud GaussDB during private SCRAM auth). The fix is plugin-agnostic so it provides defence-in-depth for any future plugin with the same class of bug.sqle/common/instance_test.gocovering the timeout constant range and ctx cancellation contract on Ping.Test plan
go vet -mod=vendor ./sqle/common/... ./sqle/driver/...go test -mod=vendor ./sqle/common/...Refs https://github.com/actiontech/sqle-ee/issues/2758
Description
添加 DriverTypeGaussDB 常量
扩展驱动类型列表支持 GaussDB 插件注册
File Walkthrough
util.go
添加 GaussDB 常量支持sqle/driver/v2/util.go