Remove agent-skills and agent-work files from repository - #138
Merged
Conversation
Remove ~3,956 agent skill/work files (~1.7M lines) that were cluttering the main branch. These belong in a separate repo tracked as a submodule. Removed: .agent/, .agent-work/, .claude/, .codex/, .cursor/, .gemini/, .zed/, .github/agents/, .github/skills/, AGENTS.md Updated .gitignore to prevent re-addition of all agent/skill directories and cleaned up stale session-specific entries. Agent-Logs-Url: https://github.com/adamtasteslikegood/tasteslikegoodtheangularsvegancookbook/sessions/ab4e978c-9866-4342-8858-65a12412d867 Co-authored-by: adamtasteslikegood <181688233+adamtasteslikegood@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove all agent skills and agent work from main branch
Remove agent-skills and agent-work files from repository
Mar 27, 2026
Contributor
Qodana for JS30 new problems were found
☁️ View the detailed Qodana report Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Agent-Logs-Url: https://github.com/adamtasteslikegood/tasteslikegoodtheangularsvegancookbook/sessions/b56c5f60-35f0-44de-b5d2-1afc28cecdf9 Co-authored-by: adamtasteslikegood <181688233+adamtasteslikegood@users.noreply.github.com>
…ion errors Agent-Logs-Url: https://github.com/adamtasteslikegood/tasteslikegoodtheangularsvegancookbook/sessions/3fa366bd-2df0-4ab0-82e4-d95e5bde7848 Co-authored-by: adamtasteslikegood <181688233+adamtasteslikegood@users.noreply.github.com>
## Description Converts the placeholder `run-prettier-fomatting-with-reviewdog.yml` (which was a raw paste of the action's documentation) into a working GitHub Actions workflow. - **Runs on PRs** to `main` and `develop` — reviewdog annotates the PR with inline formatting suggestions - **Uses `EPMatt/reviewdog-action-prettier@v1.3.0`** — latest release (Oct 2025), pinned to commit SHA `f691104c` for supply-chain safety (post [CVE-2025-30154](https://www.cve.news/cve-2025-30154/)) - **`github-pr-review` reporter** — posts inline code suggestions that can be applied with one click - **`filter_mode: file`** — checks all changed files, not just newly added lines - **`fail_level: error`** — fails the check if formatting errors are found - **Relies on existing `.prettierrc` and `.prettierignore`** for config and file scoping - **Fixes typo** in filename: `fomatting` → `formatting` - **Skips fork PRs** — job is guarded with `if: github.event.pull_request.head.repo.full_name == github.repository` so fork PRs (where `GITHUB_TOKEN` is read-only) don't fail on the `github-pr-review` reporter The existing `ci.yml` already runs `npm run format:check` — this new workflow complements it by providing **inline PR suggestions** via reviewdog, so developers can see and fix formatting issues directly in the PR diff rather than digging through CI logs. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update - [ ] Refactoring (no functional changes) - [ ] Performance improvement - [x] CI/CD changes ## Testing No application code changed — workflow-only change. Validated YAML syntax locally. - [ ] Tests pass locally (`npm run test`) - [ ] Linting passes (`npm run lint`) - [ ] Code is formatted (`npm run format`) - [ ] Build succeeds (`npm run build`) - [ ] Type checking passes (`npm run type-check`) ## Checklist - [x] My code follows the project's style guidelines - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published ## Screenshots (if applicable) N/A ## Additional Notes **Open questions:** 1. File naming — you referenced `ruin-prettier-formating-with-reviewdog.yml`. Intentional or typo for "run"? Currently named `run-prettier-formatting-with-reviewdog.yml`. 2. `filter_mode: file` (all changed files) vs `added` (only new lines)? 3. `github-pr-review` (inline suggestions) vs `github-pr-check` (check annotations)? 4. Keep both this workflow and CI's `format:check` step, or deduplicate?
adamtasteslikegood
marked this pull request as ready for review
April 5, 2026 05:03
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes editor/agent skill definitions and agent work-state files from the main repository so they don’t continue to accumulate in git history, with the intent to manage them in a separate repo (and potentially via submodule).
Changes:
- Deletes agent “skills” content under
.agent/skills/**(scripts, references, assets, sample IO). - Deletes tracked agent work-state content (e.g.,
.agent-work/**). - Keeps application/CI-related
.github/**content intact per PR description.
Reviewed changes
Copilot reviewed 38 out of 3958 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .agent/skills/app-store-optimization/scripts/keyword_analyzer.py | Removes ASO keyword analysis script content from git tracking |
| .agent/skills/app-store-optimization/scripts/aso_scorer.py | Removes ASO score calculation script content from git tracking |
| .agent/skills/app-store-optimization/sample_input.json | Removes sample input fixture from git tracking |
| .agent/skills/app-store-optimization/references/platform-requirements.md | Removes reference documentation from git tracking |
| .agent/skills/app-store-optimization/references/keyword-research-guide.md | Removes reference documentation from git tracking |
| .agent/skills/app-store-optimization/references/aso-best-practices.md | Removes reference documentation from git tracking |
| .agent/skills/app-store-optimization/expected_output.json | Removes sample output fixture from git tracking |
| .agent/skills/app-store-optimization/assets/aso-audit-template.md | Removes template asset from git tracking |
| .agent/skills/app-store-optimization/SKILL.md | Removes skill definition from git tracking |
| .agent/skills/app-store-optimization/README.md | Removes skill README from git tracking |
| .agent/skills/app-store-optimization/HOW_TO_USE.md | Removes skill usage guide from git tracking |
| .agent/skills/api-design-reviewer/references/rest_design_rules.md | Removes API design reference documentation from git tracking |
| .agent/skills/api-design-reviewer/references/api_antipatterns.md | Removes API design reference documentation from git tracking |
| .agent/skills/api-design-reviewer/SKILL.md | Removes skill definition from git tracking |
| .agent/skills/agile-product-owner/scripts/user_story_generator.py | Removes user story generator script from git tracking |
| .agent/skills/agile-product-owner/references/user-story-templates.md | Removes reference documentation from git tracking |
| .agent/skills/agile-product-owner/references/sprint-planning-guide.md | Removes reference documentation from git tracking |
| .agent/skills/agile-product-owner/SKILL.md | Removes skill definition from git tracking |
| .agent/skills/agent-designer/references/tool_design_best_practices.md | Removes reference documentation from git tracking |
| .agent/skills/agent-designer/references/agent_architecture_patterns.md | Removes reference documentation from git tracking |
| .agent/skills/agent-designer/expected_outputs/sample_tool_schemas.json | Removes expected output fixture from git tracking |
| .agent/skills/agent-designer/expected_outputs/sample_agent_architecture.json | Removes expected output fixture from git tracking |
| .agent/skills/agent-designer/assets/sample_tool_descriptions.json | Removes sample asset from git tracking |
| .agent/skills/agent-designer/assets/sample_system_requirements.json | Removes sample asset from git tracking |
| .agent/skills/agent-designer/assets/sample_execution_logs.json | Removes sample asset from git tracking |
| .agent/skills/agent-designer/SKILL.md | Removes skill definition from git tracking |
| .agent/skills/agent-designer/README.md | Removes skill README from git tracking |
| .agent-work/plan.md | Removes tracked agent work plan/state file from git tracking |
Comments suppressed due to low confidence (1)
.agent-work/plan.md:1
- The PR description calls out updating
.gitignoreto prevent re-adding these directories and mentions moving skills to a separate repo/submodule, but the provided diffs only show deletions (no.gitignore/.gitmoduleschanges are visible here). If those changes are missing from the actual PR, please add them so the removed directories don’t get reintroduced and the intended submodule setup is represented in-repo.
…skills-and-work
Conflicts:
.agent/skills/dependency-auditor/test-project/package.json
.claude/skills/dependency-auditor/test-project/package.json
.codex/skills/dependency-auditor/test-project/package.json
.cursor/skills/dependency-auditor/test-project/package.json
.gemini/skills/dependency-auditor/test-project/package.json
.github/skills/dependency-auditor/test-project/package.json
.gitignore
.zed/skills/dependency-auditor/test-project/package.json
AGENTS.md
It looks like you may be committing a merge.
If this is not correct, please run
git update-ref -d MERGE_HEAD
and try again.
Please enter the commit message for your changes. Lines starting
with '#' will be ignored, and an empty message aborts the commit.
On branch copilot/remove-agent-skills-and-work
Your branch is up to date with 'origin/copilot/remove-agent-skills-and-work'.
All conflicts fixed but you are still merging.
Changes to be committed:
deleted: .directory
deleted: .eslintrc.json
modified: .github/dependabot.yml
modified: .github/workflows/ci.yml
new file: .github/workflows/codeql-analysis.yml
modified: .github/workflows/daily-repo-status.lock.yml
modified: .github/workflows/dependabot-automerge.yml
new file: .github/workflows/dependency-review.yml
modified: .gitignore
deleted: .ts4
deleted: Adam's_Hearty_Lentil_&_Vegetable_Soup.json
deleted: Adam's_Ultimate_Vegan_Grilled_Cheese.json
modified: COPILOT.md
deleted: Google Cloud App Designs/.Phase4_GeminiEnterprise_ReviewRecomendations.md.kate-swp
deleted: Google Cloud App Designs/NextStepsMetaPrompt copy.md
deleted: Google Cloud App Designs/cloud_buildCICD copy.md
modified: QUICK_REFERENCE.md
modified: README.md
modified: START_HERE.md
deleted: cloud_build_tipsFORMAT.md
deleted: commit-phase-1.sh
modified: docs/CI_CD/CI_QUICK_REFERENCE.md
modified: docs/DOCUMENTATION_INDEX.md
modified: docs/GETTING_STARTED_CI.md
deleted: docs/PHASE_2/git_guides_submodules_best_practice/CHANGELOG_SECURITY.md
deleted: docs/PHASE_2/git_guides_submodules_best_practice/GIT_ANSWER_SUMMARY.md
deleted: docs/PHASE_2/git_guides_submodules_best_practice/GIT_CHEAT_SHEET.md
deleted: docs/PHASE_2/git_guides_submodules_best_practice/GIT_COMMANDS_COPYPASTE.md
deleted: docs/PHASE_2/git_guides_submodules_best_practice/GIT_GUIDES_README.md
deleted: docs/PHASE_2/git_guides_submodules_best_practice/GIT_QUICK_REFERENCE.md
deleted: docs/PHASE_2/git_guides_submodules_best_practice/GIT_SUBMODULE_COMPLETE_ANSWER.md
deleted: docs/PHASE_2/git_guides_submodules_best_practice/GIT_SUBMODULE_COMPLETE_INDEX.md
deleted: docs/PHASE_2/git_guides_submodules_best_practice/GIT_SUBMODULE_WORKFLOW.md
deleted: docs/PHASE_2/git_guides_submodules_best_practice/GIT_WORKFLOW_VISUAL.md
deleted: docs/backup_copies/ARCHITECTURE_RECOMMENDATION copy.md
deleted: docs/backup_copies/CHANGELOG_SECURITY copy.md
deleted: docs/backup_copies/DEPLOYMENT_CHECKLIST copy.md
deleted: docs/backup_copies/DEVELOPER_GUIDE copy.md
deleted: docs/backup_copies/DOCUMENTATION_INDEX copy.md
deleted: docs/backup_copies/IMPLEMENTATION_COMPLETE copy.md
deleted: docs/backup_copies/PHASE_1_ARCHITECTURE_DIAGRAM copy.md
deleted: docs/backup_copies/PHASE_1_COMPLETE copy.md
deleted: docs/backup_copies/PHASE_1_DOCUMENTATION_INDEX copy.md
deleted: docs/backup_copies/PHASE_1_IMPLEMENTATION_SUMMARY copy.md
deleted: docs/backup_copies/cloud_build_tips copy.md
deleted: docs/backup_copies/cloud_build_tipsFORMAT copy.md
renamed: cloud_build_tips.md -> docs/cloud_build_tips.md
new file: docs/cloud_build_tipsFORMAT.md
renamed: docs/serectsguidelines.md -> docs/secretsguidelines.md
deleted: git-workflow.sh
deleted: linuxarch101.md
deleted: lolcat
modified: metadata.json
deleted: model_discovery_output.txt
modified: package-lock.json
modified: package.json
deleted: sample_sessiondata.json
deleted: scripts/#README.md#
modified: server/index.ts
modified: src/app.component.html
modified: src/app.component.ts
modified: src/services/auth.service.ts
modified: src/services/gemini.service.ts
modified: src/services/persistence.service.ts
modified: tsconfig.json
--conflits reslover ;)
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned Files
|
20 tasks
adamtasteslikegood
added a commit
that referenced
this pull request
Apr 10, 2026
…107) (#170) ## Description Clean replacement for PR #107 (`deploy-with-db` → `main`). PR #107 showed 4,035 changed files, but ~3,955 were stale `.agent/`, `.claude/`, `.codex/`, etc. skill files that `main` already removed (via PRs #138/#139). The `deploy-with-db` branch diverged significantly from `main` (38 commits ahead, 41 behind) with 15 merge conflicts — making it unmergeable as-is. This PR cherry-picks **only the valuable source code changes** from `deploy-with-db` onto current `main`, cleanly and conflict-free. ### What's included: - **Valkey/Redis rate limiting** (`server/valkey.ts`): Distributed rate limiting with GCP Memorystore IAM auth and automatic token refresh. Properly cleans up ioredis connections on startup failure via `shutdownValkey()` to prevent leaked socket handles. - **Async server startup** (`server/index.ts`): Valkey integration, graceful SIGTERM/SIGINT shutdown. Helmet security headers and request logging are applied before the Flask proxy so they cover proxied `/api/*` responses. - **Per-IP rate limiting** (`server/security.ts`): Valkey-backed RedisStore, image serving exempt from limits - **Auth improvements** (`src/services/auth.service.ts`): Stale Google session → guest downgrade, cookbook merge fix, restore re-adds cookbook membership - **Persistence retry** (`src/services/persistence.service.ts`): Up to 2 retries for `loadFromApi` after OAuth redirect - **Type enhancement** (`src/auth.types.ts`): `cookbookIds` on `DeletedRecipe` for restore-with-membership - **12 new tests** (`server/server.test.ts`): Valkey client lifecycle + rate-limit skip logic ### What's NOT included (intentionally): - ~3,955 stale agent-skill files (already deleted on `main`) - CI/CD workflow changes (significantly diverged; should be a separate PR) - Backend submodule update (requires separate coordination) ### Branch analysis (for reference): | Branch | Unique vs main | Status | |---|---|---| | `deploy-with-db` | 38 ahead, 41 behind | Has Valkey, auth fixes, but polluted with old agent files | | `dev/integration_angular_x_flask` | 28 ahead, 214 behind | Frozen since Mar 30 | | `main` | — | Current production baseline | **Recommendation:** Close PR #107 after merging this PR. The workflow/CI changes from `deploy-with-db` can follow in a separate targeted PR. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update - [ ] Refactoring (no functional changes) - [ ] Performance improvement - [ ] CI/CD changes ## Testing All 26 tests pass (13 existing + 12 new + 1 updated). Build succeeds. CodeQL clean. - [x] Tests pass locally (`npm run test`) - [ ] Linting passes (`npm run lint`) — pre-existing failure on `main` (ESLint 10 missing `@eslint/js`) - [ ] Code is formatted (`npm run format`) - [x] Build succeeds (`npm run build`) - [ ] Type checking passes (`npm run type-check`) ## Checklist - [x] My code follows the project's style guidelines - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published ## Screenshots (if applicable) N/A ## Additional Notes New dependencies added (all advisory-clean): - `ioredis@^5.10.1` — Redis client for Valkey - `rate-limit-redis@^4.3.1` — RedisStore adapter for express-rate-limit - `google-auth-library@^10.6.2` — GCP IAM token for Valkey auth The Valkey integration gracefully falls back to in-memory rate limiting when `VALKEY_HOST` is not set, so this is backwards-compatible with existing deployments. ### Review feedback addressed: - **Connection leak fix** (`server/valkey.ts`): Catch path now calls `shutdownValkey()` instead of `client = null` to properly close any ioredis connection created before a ping/setup failure, preventing leaked socket handles. - **Misleading doc reference removed** (`server/valkey.ts`): Removed "Mirrors the pattern in Backend/utils/valkey_auth.py" from the file header since that path doesn't exist in this repository. - **Middleware ordering fix** (`server/index.ts`): Moved `applySecurityMiddleware(app)` and `createRequestLogger()` before the Flask proxy mount so Helmet security headers and request telemetry apply to all responses, including proxied `/api/*` traffic. - **Docstring accuracy fix** (`src/services/persistence.service.ts`): Corrected `loadFromApi()` docstring to accurately state the awaited loop guarantees sequential retries within a single invocation, but does not by itself prevent separate invocations from overlapping.
adamtasteslikegood
pushed a commit
that referenced
this pull request
Jul 4, 2026
…Backend pin Resolves the 15-file conflict set from dev having moved 27 commits since the release branch diverged: - workflows: dev's newer action versions kept, branch's Node 26 pin re-applied (matches node:26-alpine Dockerfile on both sides) - package.json: dev's Angular 22.0.5 + typescript 6.0.3 kept; branch's @google/genai 2.x, @types/express-rate-limit removal, and hono override kept; lockfile regenerated - .claude/settings.json: dev's version (hook already registered with $CLAUDE_PROJECT_DIR path); branch's duplicate hooks block dropped - .gitignore / AGENTS.md: union of both sides - qodana workflow + stray mail file: branch deletions kept - Backend pin: 10910bc -> 308ea06, picking up the styled SSR public shell + SEO (#132) and Gemini Dispatch CI removal (#138); single migration head c60f6530f4ff verified Verified: type-check, lint, 40 vitest tests, ng build, prettier. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
adamtasteslikegood
added a commit
that referenced
this pull request
Jul 4, 2026
Updates the [0.3.0] section before the dev→main release PR: release date → 2026-07-04, and folds in everything that landed after the section was written — Angular 22 + TypeScript 6 (#3009), the Valkey TLS CA fix (#3027), the styled public shell + SEO (Backend #132), GCP monitoring MCP (#3008), the Gemini Dispatch CI removal (Backend #138), and the Backend pin update 10910bc → 308ea06. Also corrects the now-wrong '@angular-eslint held at 21.x' note. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- Rovo Dev code review status --> --- Rovo Dev code review: <strong>Rovo Dev has reviewed this pull request</strong> Any suggestions or improvements have been posted as pull request comments. <!-- /Rovo Dev code review status --> Co-authored-by: Adam Schoen <adamschoen3@tasteslikegood.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Agent skill definitions and work files (~3,956 files, ~1.7M lines) were accumulating on the main branch. These belong in a separate repo (
adamtasteslikegood/alirez_claude_skills) tracked as a submodule.Removed from git tracking:
.agent/,.claude/,.codex/,.cursor/,.gemini/,.zed/— skill definitions mirrored across 6 editor integrations.github/agents/,.github/skills/— GitHub-specific agent/skill copies.agent-work/— agent work tracking stateAGENTS.md— top-level agent documentation.gitignoreupdated:.agent-work/cleaned up into a single.agent-work/globNon-agent
.github/files (workflows, templates, dependabot, copilot-instructions) are preserved.Type of Change
Testing
No application code changed — only agent/skill content files and
.gitignore.npm run test)npm run lint)npm run format)npm run build)npm run type-check)Checklist
Screenshots (if applicable)
N/A — no UI changes.
Additional Notes
The removed skills can be re-added later as a git submodule pointing to
adamtasteslikegood/alirez_claude_skills.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.