Summary
The repository-wide pre-land audit requested by #7585 found two additional 3.1.x specialisms with the same governance leak:
static/compliance/source/specialisms/sales-guaranteed/index.yamlstatic/compliance/source/specialisms/sales-non-guaranteed/index.yaml
On origin/3.1.x, each file:
- lists
sync_governance in required_tools,
- executes one
sync_governance step,
- later executes
create_media_buy, and
- supplies neither
plan_id nor governance_context.
Counts for each file are sync_governance=1, create_media_buy=1, plan_id=0, governance_context=0. The registration therefore changes the account contract before a context-free commitment, reproducing the defect described in #7585. Shared account natural keys also allow bindings from other storyboards to leak into these baselines.
Main-line evidence
origin/main already treats both files as explicitly ungoverned baselines: sync_governance is absent from required_tools and phases, and the narrative explains that governance-aware coverage belongs to the dedicated governance specialism/scenarios. The main-line versions therefore have sync_governance=0, create_media_buy=1.
This difference was not part of #7600 because main was already clean. It surfaced only when auditing the stable source tree for the #7585 backport.
Ask
Backport the ungoverned-baseline shape to 3.1.x without importing 3.2-only fields:
- Remove
sync_governance from required_tools, storyboard context, and phases in both files.
- Isolate and consistently reuse each storyboard's account natural key so prior governance bindings cannot leak across scenarios.
- Extend the stable regression test to include both specialisms.
- Add a patch changeset.
This should block #7559 until resolved or explicitly waived.
Refs #7585, #7600.
Summary
The repository-wide pre-land audit requested by #7585 found two additional 3.1.x specialisms with the same governance leak:
static/compliance/source/specialisms/sales-guaranteed/index.yamlstatic/compliance/source/specialisms/sales-non-guaranteed/index.yamlOn
origin/3.1.x, each file:sync_governanceinrequired_tools,sync_governancestep,create_media_buy, andplan_idnorgovernance_context.Counts for each file are
sync_governance=1,create_media_buy=1,plan_id=0,governance_context=0. The registration therefore changes the account contract before a context-free commitment, reproducing the defect described in #7585. Shared account natural keys also allow bindings from other storyboards to leak into these baselines.Main-line evidence
origin/mainalready treats both files as explicitly ungoverned baselines:sync_governanceis absent fromrequired_toolsand phases, and the narrative explains that governance-aware coverage belongs to the dedicated governance specialism/scenarios. The main-line versions therefore havesync_governance=0,create_media_buy=1.This difference was not part of #7600 because main was already clean. It surfaced only when auditing the stable source tree for the #7585 backport.
Ask
Backport the ungoverned-baseline shape to
3.1.xwithout importing 3.2-only fields:sync_governancefromrequired_tools, storyboard context, and phases in both files.This should block #7559 until resolved or explicitly waived.
Refs #7585, #7600.