fix(docs): use serve_window_sec in TMP Identity Match overview example#4474
Closed
brandonling27 wants to merge 1 commit into
Closed
Conversation
The overview walkthrough's identity_match_response example used the legacy ttl_sec field, which fails schema validation — serve_window_sec is the required field and carries different semantics (per-package single-shot fcap, not a router cache TTL). Update the docs example, its accompanying explanation, and the corresponding test fixture to match the schema. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
IPR Policy Agreement Required@brandonling27 — thanks for the contribution. Before this PR can be merged, the AgenticAdvertising.Org IPR Policy requires your agreement. To agree, post a new comment on this PR with the exact phrase: Your signature is recorded once and covers all contributions to AAO repositories. See |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
identity_match_responseexample used the legacyttl_secfield, which fails schema validation — the schema requiresserve_window_sec.serve_window_secis a per-package single-shot fcap (the publisher must re-query Identity Match after serving once per eligible package), not a router response cache TTL. Updated the example's accompanying explanation to reflect this.tests/example-validation-simple.test.cjsso theTMP Identity Match response — web (overview walkthrough)case validates against the schema.Note: the same
ttl_secvs.serve_window_secdrift exists in the surface walkthroughs (surfaces/web.mdx,surfaces/mobile.mdx,surfaces/ctv.mdx,surfaces/retail-media.mdx,surfaces/ai-assistants.mdx) and incontext-and-identity.mdx. Those aren't covered by the current validation test and are left for a follow-up to keep this PR scoped to the failing test.Test plan
node tests/example-validation-simple.test.cjs— 36/36 passing; the previously failingTMP Identity Match response — web (overview walkthrough)case now passes.docs/trusted-match/index.mdxStep 4 cleanly with the new explanation.🤖 Generated with Claude Code