support x86_64#22
Open
chengxuncc wants to merge 1 commit intoadmonstrator:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for x86_64 architecture by mapping it to the amd64 naming convention in several script functions.
- Introduce x86_64 branch in
preflight_checkto setTINY_ARCHand log architecture. - Extend
get_latest_tailscale_versionandcompress_binariesto handle amd64 binaries for x86_64. - Maintain existing logic for aarch64 and armv7l.
Comments suppressed due to low confidence (1)
update-tailscale.sh:67
- The new x86_64 branches in
preflight_check,get_latest_tailscale_version, andcompress_binariesare not covered by existing tests. Consider adding tests to validate amd64 behavior.
if [ "$ARCH" = "x86_64" ]; then
Owner
|
I don't see why x86_x64 should be included since all GL devices are only based on ARM? |
Author
|
I am running OpenWRT in x86_64 VM, and I can only found this script to upgrade tailscale, it will be convenient to add x86_64. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.