Skip to content

feat(variable-binding): Adding the sling models for variable bindings#1884

Closed
DhruvSharma-845 wants to merge 2 commits into
devfrom
forms-25503
Closed

feat(variable-binding): Adding the sling models for variable bindings#1884
DhruvSharma-845 wants to merge 2 commits into
devfrom
forms-25503

Conversation

@DhruvSharma-845
Copy link
Copy Markdown
Contributor

@DhruvSharma-845 DhruvSharma-845 commented May 16, 2026

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@DhruvSharma-845 DhruvSharma-845 self-assigned this May 16, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2026

Codecov Report

❌ Patch coverage is 68.29268% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ore/components/util/AbstractFormComponentImpl.java 71.87% 5 Missing and 4 partials ⚠️
...s/core/components/models/form/VariableBinding.java 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@adobe-bot
Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious

@adobe-bot
Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
page-has-heading-one moderate
target-size serious

@adobe-bot
Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious

1 similar comment
@adobe-bot
Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants