Skip to content

fix(6.5-lts): update aem-replication skill to reference code-assessment instead of best-practices#209

Open
Himanich wants to merge 2 commits into
mainfrom
fix/6.5-lts-best-practice-to-code-assessment
Open

fix(6.5-lts): update aem-replication skill to reference code-assessment instead of best-practices#209
Himanich wants to merge 2 commits into
mainfrom
fix/6.5-lts-best-practice-to-code-assessment

Conversation

@Himanich

Copy link
Copy Markdown
Collaborator

Description

The best-practices skill under aem-cloud-service was eliminated in favour of the code-assessment skill (which restructured replication content into a dedicated replication/SKILL.md sub-skill). The reference in the 6.5-lts aem-replication skill's migration section still pointed to the old best-practices/references/replication.md path. This updates it to the correct code-assessment/replication/SKILL.md location.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

Tessl Skill Lint

⚠️ edge-delivery-services — 1 warning(s)
⚠ tile.json is deprecated. Migrate to .tessl-plugin/plugin.json to publish a plugin-shape package. Run `tessl plugin migrate` to convert automatically. tile.json support will be removed in a future release.

✔ Plugin adobe/aem-edge-delivery-services@0.1.0 is valid
⚠️ stardust — 1 warning(s)
⚠ tile.json is deprecated. Migrate to .tessl-plugin/plugin.json to publish a plugin-shape package. Run `tessl plugin migrate` to convert automatically. tile.json support will be removed in a future release.

✔ Plugin adobe/stardust@0.13.1 is valid

✅ All 2 tile(s) lint passed with 2 warning(s) total.

Updated by tessl-lint for commit 7364039.

…t instead of best-practices

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Himanich Himanich force-pushed the fix/6.5-lts-best-practice-to-code-assessment branch from b7714f3 to 78bcbd0 Compare June 23, 2026 13:54
@Himanich

Copy link
Copy Markdown
Collaborator Author

@akankshajain18 Will you be able to review the low tessl score for this skill?

…rview

Adds explicit trigger terms and a "Use when..." clause to the description,
condenses the duplicated Skill Overview section, and adds a clarification
fallback step to How to Use — addressing tessl-review quality feedback
without changing routing behavior.

@abhishekgarg18 abhishekgarg18 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Himanich,

Strengths

  • The reference target itself is real and correct in content: the old best-practices/references/replication.md location is genuinely gone, and the new target's migration guidance (Replicator to Sling Distribution API patterns, agent selection, async handling) matches what this section promises.
  • The "Use when..." clause pulls real trigger terms (publish, unpublish, flush dispatcher cache, stuck/blocked replication queues) straight from the sub-skills it routes to, which should improve routing recall without overclaiming.
  • The Skill Overview condensation is lossless. Every mechanism in the old five verbose subsections survives in the new one-liners, and the detail that was cut was genuinely duplicated in each sub-skill's own SKILL.md.
  • The added fallback step ("If the request doesn't clearly match a single row, ask the user to clarify before proceeding") closes a real gap in a pure-router skill that previously had no defined behavior for ambiguous intent.

Issues

Important (Should Fix)

  • plugins/aem/6.5-lts/skills/aem-replication/SKILL.md:88 - This reference crosses a plugin boundary that isn't guaranteed to exist. aem-6.5-lts and aem-cloud-service are separate, independently installable plugins in this marketplace (plugins/aem/6.5-lts and plugins/aem/cloud-service). A user who installs only aem-6.5-lts will have this line point at a code-assessment skill file that simply is not present in their installation, regardless of whether the path string itself is correct. On top of that, the path prefix as written (skills/aem/cloud-service/skills/code-assessment/replication/SKILL.md) doesn't match any real location in this repo either way - there's no top-level skills/ directory, and the plugin manifest sources plugins from plugins/aem/.... This pre-existing prefix convention shows up in a few other files too, so it's not new to this PR, but since the entire point of this PR is fixing a dangling cross-skill reference, it's worth resolving both problems on this line: use the real path (plugins/aem/cloud-service/skills/code-assessment/replication/SKILL.md) and make the cross-plugin dependency explicit (e.g., "requires the aem-cloud-service plugin") so it's clear this pointer only resolves if that plugin is also installed.

@akankshajain18

Copy link
Copy Markdown
Collaborator

@akankshajain18 Will you be able to review the low tessl score for this skill?

The tessl-review failure isn't caused by this PR's actual change (swapping the best-practices reference for code-assessment in aem-replication/SKILL.md) — it's the Tessl judge re-scoring the whole aem-replication skill on this touch, and it comes back at 69%, below the 80% gate.

findings:

  • Description (68%) — missing an explicit "Use when..." clause and natural trigger terms like publish, unpublish, flush dispatcher, replication queue.
  • Content (57%) — the "Skill Overview" and "Common Workflows" sections duplicate detail that already lives in each sub-skill's own SKILL.md; "How to Use" has no fallback step for ambiguous intent.

it will be good if someone from replication history look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants