fix(6.5-lts): update aem-replication skill to reference code-assessment instead of best-practices#209
Open
Himanich wants to merge 2 commits into
Open
fix(6.5-lts): update aem-replication skill to reference code-assessment instead of best-practices#209Himanich wants to merge 2 commits into
Himanich wants to merge 2 commits into
Conversation
Tessl Skill Lint
|
…t instead of best-practices Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
b7714f3 to
78bcbd0
Compare
Collaborator
Author
|
@akankshajain18 Will you be able to review the low tessl score for this skill? |
rombert
approved these changes
Jun 26, 2026
…rview Adds explicit trigger terms and a "Use when..." clause to the description, condenses the duplicated Skill Overview section, and adds a clarification fallback step to How to Use — addressing tessl-review quality feedback without changing routing behavior.
abhishekgarg18
left a comment
Member
There was a problem hiding this comment.
Hey @Himanich,
Strengths
- The reference target itself is real and correct in content: the old
best-practices/references/replication.mdlocation is genuinely gone, and the new target's migration guidance (Replicator to Sling Distribution API patterns, agent selection, async handling) matches what this section promises. - The "Use when..." clause pulls real trigger terms (publish, unpublish, flush dispatcher cache, stuck/blocked replication queues) straight from the sub-skills it routes to, which should improve routing recall without overclaiming.
- The Skill Overview condensation is lossless. Every mechanism in the old five verbose subsections survives in the new one-liners, and the detail that was cut was genuinely duplicated in each sub-skill's own SKILL.md.
- The added fallback step ("If the request doesn't clearly match a single row, ask the user to clarify before proceeding") closes a real gap in a pure-router skill that previously had no defined behavior for ambiguous intent.
Issues
Important (Should Fix)
- plugins/aem/6.5-lts/skills/aem-replication/SKILL.md:88 - This reference crosses a plugin boundary that isn't guaranteed to exist.
aem-6.5-ltsandaem-cloud-serviceare separate, independently installable plugins in this marketplace (plugins/aem/6.5-ltsandplugins/aem/cloud-service). A user who installs onlyaem-6.5-ltswill have this line point at acode-assessmentskill file that simply is not present in their installation, regardless of whether the path string itself is correct. On top of that, the path prefix as written (skills/aem/cloud-service/skills/code-assessment/replication/SKILL.md) doesn't match any real location in this repo either way - there's no top-levelskills/directory, and the plugin manifest sources plugins fromplugins/aem/.... This pre-existing prefix convention shows up in a few other files too, so it's not new to this PR, but since the entire point of this PR is fixing a dangling cross-skill reference, it's worth resolving both problems on this line: use the real path (plugins/aem/cloud-service/skills/code-assessment/replication/SKILL.md) and make the cross-plugin dependency explicit (e.g., "requires theaem-cloud-serviceplugin") so it's clear this pointer only resolves if that plugin is also installed.
Collaborator
The tessl-review failure isn't caused by this PR's actual change (swapping the best-practices reference for code-assessment in aem-replication/SKILL.md) — it's the Tessl judge re-scoring the whole aem-replication skill on this touch, and it comes back at 69%, below the 80% gate. findings:
it will be good if someone from replication history look into it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The best-practices skill under aem-cloud-service was eliminated in favour of the code-assessment skill (which restructured replication content into a dedicated replication/SKILL.md sub-skill). The reference in the 6.5-lts aem-replication skill's migration section still pointed to the old best-practices/references/replication.md path. This updates it to the correct code-assessment/replication/SKILL.md location.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: