Skip to content

FIX: Align ZipPath.root with pathlib#24

Draft
Mirochill wants to merge 1 commit into
aiidateam:mainfrom
Mirochill:fix-18-zippath-root
Draft

FIX: Align ZipPath.root with pathlib#24
Mirochill wants to merge 1 commit into
aiidateam:mainfrom
Mirochill:fix-18-zippath-root

Conversation

@Mirochill
Copy link
Copy Markdown

Summary

  • Make ZipPath.root describe the root portion of the internal archive path, matching pathlib behavior.
  • Add ZipPath.zipfile as the explicit accessor for the underlying ZipFile handle.
  • Update internal uses and add a regression covering root and zipfile on child paths.

Validation

  • Not run locally.
  • git diff --check
  • git diff --cached --check
  • git diff --check HEAD~1..HEAD
  • git show --stat --oneline HEAD -- archive_path/zip_path.py tests/test_basic.py

Closes #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZipPath.root is different from PurePath.root

1 participant