Promote staging to main: fix the release job's release notes - #1005
Merged
Merged
Conversation
… a plugin return type
…-preset fix(deps): pair the changelog preset with the release-notes writer
|
promotion PR — structural quality was gated per feature PR on staging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This brings one change from
stagingtomain: #1004, which fixes the release job.The release job runs only on
main. It failed on 29 September while generating release notes, so v0.8.0 was deployed without a tag or changelog entry. #1004 movesconventional-changelog-conventionalcommitsto^9.3.1, the newest major that works with the writer our release-notes generator loads. Releases since 0.5.0 have had empty notes for the same reason.What changes on
mainpackage.jsonandpnpm-lock.yaml(dev dependency only)..releaserc.jsonwith the real plugins..releaserc.jsonadded to the build workflow's path lists.No application code changes. The production app is rebuilt and restarted as usual when this merges.
Expected after merge
The Release workflow should tag
v0.8.0, add a 0.8.0 entry with sections toCHANGELOG.md, publish a GitHub release with the same notes, and mergemainback intostaging.Checks
#1004's CI and the staging build and deploy of its merge commit both passed.