Security: Untrusted package installation from catalog config enables arbitrary code execution#731
Open
tuanaiseo wants to merge 1 commit intoalan-turing-institute:mainfrom
Conversation
… config `install_package()` builds a pip target directly from `config["url"]`/`config["github_branch"]` and installs it when `allow_install` is enabled. If a catalog/model config is attacker-controlled (or tampered), this can install and execute malicious package code during install/import. Affected files: installer.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
install_package()builds a pip target directly fromconfig["url"]/config["github_branch"]and installs it whenallow_installis enabled. If a catalog/model config is attacker-controlled (or tampered), this can install and execute malicious package code during install/import.Severity:
criticalFile:
src/scivision/io/installer.pySolution
Treat config as untrusted input: enforce a strict allowlist of approved package sources, require immutable pinned commit SHAs/tags (not branches), verify package integrity/signatures, and keep
allow_install=Falseby default for runtime paths.Changes
src/scivision/io/installer.py(modified)Testing