Security: Dynamic import and callable selection from config allows attacker-controlled code execution#732
Open
tuanaiseo wants to merge 1 commit intoalan-turing-institute:mainfrom
Conversation
…config `AutoPlumber`/`DataPlumber` import modules and resolve classes/functions from config fields (`import`, `model`, `class`, `func.call`) and invoke them. A malicious config can point to dangerous modules or attacker-installed code, resulting in arbitrary code execution. Affected files: autoplumber.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AutoPlumber/DataPlumberimport modules and resolve classes/functions from config fields (import,model,class,func.call) and invoke them. A malicious config can point to dangerous modules or attacker-installed code, resulting in arbitrary code execution.Severity:
highFile:
src/scivision/io/autoplumber.pySolution
Validate config against a strict schema and allowlist of permitted modules/classes/functions; disallow arbitrary import paths; isolate plugin execution in a sandboxed process with least privilege.
Changes
src/scivision/io/autoplumber.py(modified)Testing