build: don't set global compiler flags

[tearfur]

P.S. Maybe this macro can be removed altogether? Not sure what it is for in the first place.

[alandefreitas]

Wouldn't

if (SMALL_MASTER_PROJECT)
    set_optimization_flags()
endif()

at the calling site be a shorter diff with better separation of concerns?

[tearfur]

Changed per your suggestion and provided a fallback if people wanted the old behaviour.

[alandefreitas]

Sorry. Just had another look at this whole thing. The correct approach would be for none of that to even exist, let alone different behaviors for MASTER/ROOT and subdirs. If user is responsible for choosing the build type and the build type already sets the flags. So that's it. This function shouldn't exist and we should never call it.

[alandefreitas]

LGTM! Thanks!