[Backend] Fix explicit pooling pads and CUDA TopKV2 largest flag#4627
Open
Fatemanx wants to merge 2 commits into
Open
[Backend] Fix explicit pooling pads and CUDA TopKV2 largest flag#4627Fatemanx wants to merge 2 commits into
Fatemanx wants to merge 2 commits into
Conversation
Collaborator
|
Thanks for the fix! Verified on x86 Linux + CUDA (RTX 3090): both new tests fail on current master, confirming the bugs this PR addresses.
Suggestions on test organization:
Thanks again for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pads()for non-global pooling across CPU, CUDA, and OpenCL paths.largestsolargest=falsereturns the smallest values.Related Issue
Related to #4613
Test Plan
cmake --build build_cuda -j$(nproc) --target run_test.out./build_cuda/run_test.out op/CUDAMaxPoolExplicitPads 0 0 0./build_cuda/run_test.out op/CUDAMaxPoolExplicitPads 2 0 0./build_cuda/run_test.out op/CUDATopKV2LargestFlag 0 0 0./build_cuda/run_test.out op/CUDATopKV2LargestFlag 2 0 0./build_cuda/run_test.out op/TopKV2 0 0 0./build_cuda/run_test.out op/TopKV2 2 0 0./test.sh staticOpenCL execution was not run locally because this environment does not provide an OpenCL executor.