Skip to content

fix: detect throttling by x-acs-retry-after header#1395

Merged
yndu13 merged 1 commit into
masterfrom
feature/aone-84496165-throttling-retry-after-header
Jul 21, 2026
Merged

fix: detect throttling by x-acs-retry-after header#1395
yndu13 merged 1 commit into
masterfrom
feature/aone-84496165-throttling-retry-after-header

Conversation

@yndu13

@yndu13 yndu13 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Classic OpenAPI and V2 client throttling retry now key off x-acs-retry-after / RetryAfter.
  • Stop requiring error Code to contain Throttling.
  • Update unit tests for non-Throttling codes that still carry retry-after.

Retry when the response carries x-acs-retry-after (or ThrottlingError
with RetryAfter), without requiring the error code to contain
"Throttling".
@codecov-commenter

codecov-commenter commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.85%. Comparing base (6367498) to head (a3f4750).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1395      +/-   ##
==========================================
- Coverage   84.86%   84.85%   -0.01%     
==========================================
  Files          69       69              
  Lines        8951     8947       -4     
==========================================
- Hits         7596     7592       -4     
  Misses        915      915              
  Partials      440      440              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yndu13
yndu13 merged commit 406a10a into master Jul 21, 2026
6 checks passed
@yndu13
yndu13 deleted the feature/aone-84496165-throttling-retry-after-header branch July 21, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants