Bringing Amex Tokenization to live#4
Open
Pranen wants to merge 8 commits intoamericanexpress:masterfrom
Open
Conversation
|
|
…client Adding system properties to the httpclients.custom().builder
Contributor
Sunny-Hirani
left a comment
There was a problem hiding this comment.
@Pranen - Thank you for the proposed changes, Could you remove the main method in AmexTokenizationClient.java and commented code ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request, i added the QA-Env, correct versions for the build and if you add your credentials, the amex tokenization should also work.