Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an EPA-based syllabification CLI, improves dependency workflows in the Makefile, and updates project configuration and documentation accordingly.
- Introduce
syllabifyscript and addepa-syllabifierdependency - Add new Makefile targets (
sync-dev,install-editable,demo-transliterate,demo-syllabify,add-dep) and updatetestto usesync-dev - Update
pyproject.toml,dev-requirements.txt, andREADME.mdto reflect the new tool and workflows
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pyproject.toml | Added epa-syllabifier to dependencies and included bin/syllabify in script-files |
| dev-requirements.txt | Added epa-syllabifier==0.3.0 under development requirements |
| README.md | Clarified CLI usage, added file transliteration example, and documented the new syllabify tool |
| Makefile | Set default goal, added sync-dev, install-editable, demo-* targets, updated test to use sync-dev, and introduced add-dep |
Comments suppressed due to low confidence (1)
README.md:59
- [nitpick] Rephrase to 'You can also transliterate files using the
-ioption:' for smoother English phrasing.
You also can transliterate files using the `-i` option:
Comment on lines
+33
to
+36
| install-editable: check-uv sync ## Instala el módulo andaluh en modo desarrollo | ||
| @echo "⚙️ Instalando módulo andaluh en modo desarrollo..." | ||
| @uv pip install -e . | ||
| @echo "✅ Módulo andaluh instalado en modo desarrollo" |
There was a problem hiding this comment.
[nitpick] The 'install-editable' target duplicates the 'install' target. Consider consolidating these to avoid duplicated logic.
Suggested change
| install-editable: check-uv sync ## Instala el módulo andaluh en modo desarrollo | |
| @echo "⚙️ Instalando módulo andaluh en modo desarrollo..." | |
| @uv pip install -e . | |
| @echo "✅ Módulo andaluh instalado en modo desarrollo" | |
| install-editable: install ## Alias para instalar el módulo andaluh en modo desarrollo |
| @uv pip install -e . | ||
| @echo "✅ Módulo andaluh instalado en modo desarrollo" | ||
|
|
||
| install-editable: check-uv sync ## Instala el módulo andaluh en modo desarrollo |
There was a problem hiding this comment.
The 'install-editable' target depends on 'sync', which no longer installs development dependencies. You may want to depend on 'sync-dev' instead to ensure dev dependencies are available.
Suggested change
| install-editable: check-uv sync ## Instala el módulo andaluh en modo desarrollo | |
| install-editable: check-uv sync-dev ## Instala el módulo andaluh en modo desarrollo |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and new features to the
Makefileand project configuration, primarily focused on improving dependency management, adding new CLI tools, and updating documentation. The most significant changes include the addition of a syllabification tool (syllabify), updates to theMakefilefor better development workflows, and updates to the project dependencies and documentation.Enhancements to the
Makefile:sync-dev,install-editable,demo-transliterate,demo-syllabify, andadd-depto streamline development workflows and support new features. For example,sync-devhandles development dependencies, andadd-depsimplifies adding dependencies topyproject.toml. ([[1]](https://github.com/andalugeeks/andaluh-py/pull/23/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L1-R3),[[2]](https://github.com/andalugeeks/andaluh-py/pull/23/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L18-R37),[[3]](https://github.com/andalugeeks/andaluh-py/pull/23/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R127-R144))testtarget to usesync-devinstead ofsyncfor better dependency synchronization during testing. ([MakefileL50-R60](https://github.com/andalugeeks/andaluh-py/pull/23/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L50-R60))New CLI Tool: Syllabifier
syllabifyCLI tool for syllabifying words using EPA rules. This includes updates to theMakefile(demo-syllabifytarget) and documentation inREADME.md. ([[1]](https://github.com/andalugeeks/andaluh-py/pull/23/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L76-R105),[[2]](https://github.com/andalugeeks/andaluh-py/pull/23/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R59-R90))Dependency and Configuration Updates:
epa-syllabifieras a dependency inpyproject.tomlanddev-requirements.txt. Updatedpyproject.tomlto include thesyllabifyscript underscript-files. ([[1]](https://github.com/andalugeeks/andaluh-py/pull/23/files#diff-43470c4f399e798afc682f0bf6c690eef5f47ee25445904a066e4c3314f3a787R17-R18),[[2]](https://github.com/andalugeeks/andaluh-py/pull/23/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R27-R29),[[3]](https://github.com/andalugeeks/andaluh-py/pull/23/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711L46-R52))Documentation Improvements:
README.mdto include instructions for the newsyllabifytool and examples for transliterating files using theandaluhCLI. ([[1]](https://github.com/andalugeeks/andaluh-py/pull/23/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L35-R35),[[2]](https://github.com/andalugeeks/andaluh-py/pull/23/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R59-R90))