test(@angular/build): add E2E test for Vitest custom browser configuration

[clydin]

Add an E2E test to verify that the Vitest runner respects the browser configuration defined in vitest-base.config.ts when no CLI overrides are present. This ensures that custom configurations, such as specific browser providers or endpoints, are preserved when users rely solely on the configuration file.

[gemini-code-assist]

Code Review

This pull request introduces a new end-to-end test for Vitest browser support, which involves setting up a custom configuration file and verifying the browser environment via a spec file. The review feedback points out that the --runner-config flag is used incorrectly without a value and suggests removing it to properly test automatic configuration detection or providing the specific filename if testing the flag itself.

I am having trouble creating individual review comments. Click here to see my feedback.

tests/e2e/tests/vitest/browser-custom-config.ts (51)

The --runner-config flag is passed without a value. In the Angular CLI, options that expect a string (like a file path) will cause an error if the value is missing. Furthermore, the PR description states that this test verifies behavior "when no CLI overrides are present", but providing this flag on the command line constitutes an override. If the goal is to verify that the builder automatically detects and uses vitest-base.config.ts, the flag should be removed. If the goal was to test the option itself, the filename should be provided as a value (e.g. --runner-config=vitest-base.config.ts).

  const { stdout } = await ng('test', '--no-watch');

References

1. Avoid placing a comma immediately after abbreviations like 'e.g.' in user-facing messages.

[clydin]

This PR was merged into the repository. The changes were merged into the following branches:

• main: 943fe40

[angular-automatic-lock-bot]

This pull request has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}