fix(apps): prevent reflected XSS via un-encoded response#3737
Open
josephperrott wants to merge 1 commit into
Open
fix(apps): prevent reflected XSS via un-encoded response#3737josephperrott wants to merge 1 commit into
josephperrott wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the dnsRedirecting function in apps/functions/dns-redirecting/index.ts to explicitly set the response content type to 'text/plain' when returning a 404 error message. There are no review comments, and I have no further feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a reflected XSS vulnerability in the dns-redirecting cloud function by properly setting the Content-Type to text/plain before returning a 404 response.
Validated via testing and manual PoC verification.