Skip to content

fix(ng-dev): validate nvmrc-sourced Node.js version before fetch #3738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adilburaksen wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

fix(ng-dev): validate nvmrc-sourced Node.js version before fetch #3738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ng-dev/misc/sync-module-bazel/sync-module-bazel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,10 @@ async function processNodeToolchainArgs(
return args;
}

if (!semver.valid(effectiveVersion)) {
throw new Error(`Invalid Node.js version: ${effectiveVersion}`);
}
Comment on lines +142 to +144
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While semver.valid() validates the version, it also returns the cleaned/normalized version string (e.g., stripping any leading v or whitespace). If effectiveVersion contains a leading v (for example, if manually specified in MODULE.bazel), using it directly in getNodeJsRepositories will result in a URL with a double v prefix (e.g., vv24.16.0), causing the fetch to fail.

To prevent this, we should assign the normalized version returned by semver.valid() back to effectiveVersion.

Suggested change
if (!semver.valid(effectiveVersion)) {
throw new Error(`Invalid Node.js version: ${effectiveVersion}`);
}
const validatedVersion = semver.valid(effectiveVersion);
if (!validatedVersion) {
throw new Error('Invalid Node.js version: ' + effectiveVersion);
}
effectiveVersion = validatedVersion;


Log.info(`Resolving Node.js repositories for v${effectiveVersion}...`);
const repositories = await getNodeJsRepositories(effectiveVersion);
const lines = repositories.map(({filename, sha, type}) => {
Expand Down