fix(ng-dev): prevent arbitrary code execution via HTML injection#3739
Merged
alan-agius4 merged 1 commit intoJun 5, 2026
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds HTML escaping to release notes fields, including commit types, group names, descriptions, breaking changes, and deprecations, to ensure safe rendering. The review feedback suggests improving the robustness of the escapeHtml function by handling nullish values, which prevents potential runtime crashes if commit fields are malformed or missing.
josephperrott
force-pushed
the
fix-release-notes-injection
branch
from
1cb4a8f to
fcc0132
Compare
alan-agius4
approved these changes
Jun 5, 2026
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mitigates a Cross-Site Scripting (XSS) vulnerability where an attacker could inject arbitrary HTML/JavaScript into the release notes via a malicious commit message.
We implemented a robust HTML escaping mechanism for commit fields in
ng-dev/release/notes/context.tsusing named HTML entities to ensure they are safely rendered by the EJS templates.