Skip to content

fix(useAnnotations): ignore tag#97

Draft
Simon-He95 wants to merge 1 commit intoantfu:mainfrom
Simon-He95:main
Draft

fix(useAnnotations): ignore tag#97
Simon-He95 wants to merge 1 commit intoantfu:mainfrom
Simon-He95:main

Conversation

@Simon-He95
Copy link
Copy Markdown
Contributor

before: element tag become icon

image

after:

image

@antfu
Copy link
Copy Markdown
Owner

antfu commented Dec 1, 2024

But actually it's a valid usage with https://github.com/unplugin/unplugin-icons. The syntax is ambiguous; we can't just exclude the case. The solution to this is to disable el collections in the config.

@Simon-He95
Copy link
Copy Markdown
Contributor Author

In fact, el is just a special column. It may have another prefix in other component libraries. Maybe there should be a configuration to allow users to filter el or other prefixes according to actual conditions.

@Simon-He95 Simon-He95 marked this pull request as draft December 1, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants