Skip to content

GH-49948: [CI][C++] Revert PR 49931 (Pin MinGW MSYS2 packages) but keep bumped minIO version#49945

Merged
rok merged 1 commit into
apache:mainfrom
tadeja:revert-pins-from-49931
May 16, 2026
Merged

GH-49948: [CI][C++] Revert PR 49931 (Pin MinGW MSYS2 packages) but keep bumped minIO version#49945
rok merged 1 commit into
apache:mainfrom
tadeja:revert-pins-from-49931

Conversation

@tadeja
Copy link
Copy Markdown
Contributor

@tadeja tadeja commented May 7, 2026

Rationale for this change

Ready to revert pinned packages on MINGW64 with tests all passing now - see updated umbrella issue #49948 and #49958.
Past origin PR discussion #49931 (review)

What changes are included in this PR?

Reverting PR #49931's temporary pins workaround - so completely removing step - name: Setup MSYS2.

Are these changes tested?

Yes, tests now pass on current upstream MSYS2

Are there any user-facing changes?

No.

@github-actions github-actions Bot added the awaiting review Awaiting review label May 7, 2026
@tadeja tadeja force-pushed the revert-pins-from-49931 branch from 4f1af1b to 4c7390f Compare May 7, 2026 12:45
@tadeja tadeja force-pushed the revert-pins-from-49931 branch from 4c7390f to cb652aa Compare May 7, 2026 16:49
@tadeja tadeja changed the title GH-49930: [CI][C++] Revert PR 49931 (Pin MinGW MSYS2 packages) but keep bumped minIO version GH-49948: [CI][C++] Revert PR 49931 (Pin MinGW MSYS2 packages) but keep bumped minIO version May 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

⚠️ GitHub issue #49948 has been automatically assigned in GitHub to PR creator.

@tadeja
Copy link
Copy Markdown
Contributor Author

tadeja commented May 16, 2026

See updated #49948 and #49958, ready to revert pinned package versions with this PR!

GCC 125312 related fix already merged in upstream MSYS2 - Version 16.1.0-4 is available on https://packages.msys2.org/packages/mingw-w64-x86_64-gcc-libs, it downloads and allows all tests on our MinGW job to pass now:
https://github.com/apache/arrow/actions/runs/25937291262/job/76296127141#step:5:109

@tadeja tadeja marked this pull request as ready for review May 16, 2026 06:41
@tadeja tadeja force-pushed the revert-pins-from-49931 branch from cb652aa to 0e22776 Compare May 16, 2026 08:05
Copy link
Copy Markdown
Member

@rok rok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've followed the upstream development and this makes sense to me. Will merge if CI green.

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 16, 2026
@rok rok merged commit 27513af into apache:main May 16, 2026
18 checks passed
@rok rok removed the awaiting merge Awaiting merge label May 16, 2026
Copy link
Copy Markdown
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks @tadeja

@github-actions github-actions Bot added the awaiting changes Awaiting changes label May 16, 2026
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 27513af.

There was 1 benchmark result with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes Awaiting changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants