GH-50251: [C++] Add GetSpan to ArrayData#50366
Merged
Merged
Conversation
|
|
pitrou
reviewed
Jul 6, 2026
Comment on lines
+1156
to
+1157
| auto data = ArrayData::Make(uint8(), 3, buffers, 0, 1); | ||
| auto span = data->template GetMutableSpan<uint8_t>(1, 3); |
Contributor
Author
There was a problem hiding this comment.
Hi @pitrou, thank you for reviewing, I have amended the tests and formatting
github-actions
Bot
added
awaiting committer review
pitrou
requested changes
Jul 7, 2026
Member
|
Also, please make sure your changes pass the CI lint step. You can do so locally using |
…an member functions
Member
|
@dkp116 I pushed two more changes:
|
pitrou
approved these changes
Jul 7, 2026
pitrou
left a comment
pitrou
left a comment
Member
There was a problem hiding this comment.
+1, I'll wait for CI and then merge
Member
|
CI failure is unrelated. |
pitrou
changed the title
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
Add
GetSpan<T>(int i, int64_t length)for read-only typed access to ArrayData.Add
GetMutableSpan<T>(int i, int64_t length)for writable typed access to ArrayData.Are these changes tested?
Yes, new unit tests were added in
array/data_test.cc