GH-50859: [C++][Parquet] Move JsonWriter to simdjson utilities - #50990
Draft
rok wants to merge 3 commits into
Draft
GH-50859: [C++][Parquet] Move JsonWriter to simdjson utilities#50990rok wants to merge 3 commits into
rok wants to merge 3 commits into
Conversation
Parquet uses JsonWriter independently of the Arrow JSON module. Move the writer into the simdjson utility compilation unit so it is available whenever simdjson is enabled, including ARROW_JSON=OFF builds. Update CMake and Meson to compile and test it with the utility component.
Keep JsonWriter in arrow::json while moving its implementation to the simdjson utilities. This minimizes call-site changes and preserves the existing namespace.
Member
|
The CI failures need fixing. |
Member
Author
|
@pitrou done. |
Now that simdjson_internal.cc exists, move non-template helper definitions into it and leave exported declarations in the header.
Member
Author
Done |
Member
Author
|
Again, this PR is purely AI generated. I will mark as ready for review once I review myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Parquet uses JsonWriter when ARROW_JSON=OFF, but its implementation was only built with Arrow JSON, causing link failures.
What changes are included in this PR?
Move JsonWriter to the simdjson utilities and update its callers and CMake/Meson builds.
Are these changes tested?
Yes. CMake shared/static and Meson Parquet builds pass with JSON disabled. Unit tests and pre-commit checks also pass.
Are there any user-facing changes?
No. This only fixes the affected build configuration.
AI disclosure - this was AI generated to test alternative approach to #50900.