Skip to content

Automatically generate node support functions in cloudberry#1823

Open
chenjinbao1989 wants to merge 5 commits into
apache:mainfrom
chenjinbao1989:generate_read_write2
Open

Automatically generate node support functions in cloudberry#1823
chenjinbao1989 wants to merge 5 commits into
apache:mainfrom
chenjinbao1989:generate_read_write2

Conversation

@chenjinbao1989

Copy link
Copy Markdown
Contributor

When merging Postgres 16, automatic generation of node support
functions was not enabled. This commit enables the automatic
generation of write, read, copy, and equal functions.

In future code, developers will no longer need to manually create
NodeTags and their corresponding write/read/copy/equal functions
when creating or modifying structures.

*
* explain_gp.h
*
* Portions Copyright (c) 2026, Cloudberry, Inc.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there is no Cloudberry, Inc. For the new files created by the Cloudberry community members, we should add the standard ASF license headers. Can take the following as a reference:

/*-------------------------------------------------------------------------
*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*
* pax_gbench.cc
*
* IDENTIFICATION
* contrib/pax_storage/src/cpp/pax_gbench.cc
*
*-------------------------------------------------------------------------
*/

break;

case T_DynamicIndexScanState:
case T_DynamicIndexOnlyScanState:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove T_DynamicIndexOnlyScanState ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants