Automatically generate node support functions in cloudberry#1823
Open
chenjinbao1989 wants to merge 5 commits into
Open
Automatically generate node support functions in cloudberry#1823chenjinbao1989 wants to merge 5 commits into
chenjinbao1989 wants to merge 5 commits into
Conversation
tuhaihe
reviewed
Jun 18, 2026
| * | ||
| * explain_gp.h | ||
| * | ||
| * Portions Copyright (c) 2026, Cloudberry, Inc. |
Member
There was a problem hiding this comment.
Hi, there is no Cloudberry, Inc. For the new files created by the Cloudberry community members, we should add the standard ASF license headers. Can take the following as a reference:
cloudberry/contrib/pax_storage/src/cpp/pax_gbench.cc
Lines 1 to 26 in 3a64dbc
e3c9eec to
ce58074
Compare
ce58074 to
472d86e
Compare
yjhjstz
reviewed
Jun 19, 2026
| break; | ||
|
|
||
| case T_DynamicIndexScanState: | ||
| case T_DynamicIndexOnlyScanState: |
Member
There was a problem hiding this comment.
why remove T_DynamicIndexOnlyScanState ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merging Postgres 16, automatic generation of node support
functions was not enabled. This commit enables the automatic
generation of write, read, copy, and equal functions.
In future code, developers will no longer need to manually create
NodeTags and their corresponding write/read/copy/equal functions
when creating or modifying structures.