[branch-4.1](inverted-index) replace void* query_value with typed param interface (#62960)#63157
Merged
Merged
Conversation
…interface (apache#62960) A typed query-param interface replaces the void*: - InvertedIndexQueryParam (root) → StringQueryParam / NumericQueryParam (intermediates) → TypedInvertedIndexQueryParam<PT> (concrete, picks base via PT). - Readers dynamic_cast to the appropriate intermediate at entry; mismatch fail-fast with Status::InternalError. - Sentinels move into TypedInvertedIndexQueryParam::encode_min/max_ascending using type_limit<storage_val> directly — no scratch buffer, no TypeInfo callback. - TypeInfo::set_to_min/max and all its overrides are removed. - DATETIME signedness fix: storage_val = std::conditional_t<PT == TYPE_DATETIME, int64_t, ...> aligns the typed param with KeyCoder's signed view, so type_limit<int64_t>::max() = INT64_MAX produces the correct +inf byte string. (cherry picked from commit 789ec33)
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
yiguolei
approved these changes
May 20, 2026
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick from master #62960