[fix](regression) Stabilize base compaction file size limit case#65386
Open
shuke987 wants to merge 1 commit into
Open
[fix](regression) Stabilize base compaction file size limit case#65386shuke987 wants to merge 1 commit into
shuke987 wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
Collaborator
Author
|
/review |
Collaborator
Author
|
skip buildall |
Contributor
There was a problem hiding this comment.
Automated review completed for PR 65386.
No inline issues found in the changed regression test. The patch is limited to snapshotting BE config values, setting the two compaction-related BE configs needed by the case, and restoring the original per-backend values in finally.
Critical checkpoints:
- Changed-file scope: confirmed one modified file,
regression-test/suites/compaction/test_base_compaction_with_dup_key_max_file_size_limit.groovy. - Existing review context: no existing inline review comments or replies were present in
.code-review.8OsP7D/pr_review_threads.md. - Config propagation/restoration: verified
get_be_paramreturns backend-id/value maps andset_original_be_paramrestores those maps per backend. - Compaction behavior: verified the lowered
base_compaction_dup_key_max_file_size_mbytesstill matches the intended base-compaction filter path and final E-808 assertion. - User focus: no additional user-provided review focus was specified.
- Validation limit: this runner has a shallow/grafted checkout, so I used GitHub PR metadata/patches as authoritative. I did not rerun the heavy p2 regression suite locally; the PR body reports a passing remote run.
Subagent conclusions:
optimizer-rewrite: no candidates in the initial pass; convergence round 1 returnedNO_NEW_VALUABLE_FINDINGS.tests-session-config: no candidates in the initial pass; convergence round 1 returnedNO_NEW_VALUABLE_FINDINGS.- Final proposed inline comment set was empty, and convergence round 1 ended with all live subagents reporting
NO_NEW_VALUABLE_FINDINGS.
Note: I could not find the repository-local code-review SKILL.md in this checkout, including hidden paths, and no required AGENTS.md files were listed for this PR's changed-file ancestors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing