[fix](case) Relax show data compaction size check#65392
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
/review |
|
run buildall |
There was a problem hiding this comment.
Automated review summary:
I found one blocking test-coverage regression in the changed assertion logic and submitted it as an inline comment.
Critical checkpoints:
- Changed files reviewed: regression-test/suites/inverted_index_p2/test_show_data.groovy.
- Existing inline review context: none was present in .code-review.csS0H3/pr_review_threads.md, so there was no duplicate thread to suppress.
- Required AGENTS.md files: none were listed for this PR.
- Repo-local code-review SKILL.md: not found in this checkout after hidden-path searches, so the review proceeded with the prompt contract and shared-ledger workflow.
- Validation limits: the checkout is grafted/shallow and lacks the base parent locally; I used GitHub PR patch metadata as the authoritative diff. I did not run the Doris regression suite locally.
User focus: no additional user-provided review focus was supplied.
Subagent conclusions:
- optimizer-rewrite found no optimizer/rewrite, semantic-equivalence, parallel join, or aggregate-path issue.
- tests-session-config proposed TSC-1; I independently verified and accepted it as MAIN-1, now submitted as the inline comment.
- Convergence round 1 ended with both live subagents replying NO_NEW_VALUABLE_FINDINGS for the same ledger/comment set after MAIN-1 was accepted.
There was a problem hiding this comment.
Automated review summary:
I found one blocking test-coverage regression in the changed assertion logic and submitted it as an inline comment.
Critical checkpoints:
- Changed files reviewed: regression-test/suites/inverted_index_p2/test_show_data.groovy.
- Existing inline review context: none was present in .code-review.csS0H3/pr_review_threads.md, so there was no duplicate thread to suppress.
- Required AGENTS.md files: none were listed for this PR.
- Repo-local code-review SKILL.md: not found in this checkout after hidden-path searches, so the review proceeded with the prompt contract and shared-ledger workflow.
- Validation limits: the checkout is grafted/shallow and lacks the base parent locally; I used GitHub PR patch metadata as the authoritative diff. I did not run the Doris regression suite locally.
User focus: no additional user-provided review focus was supplied.
Subagent conclusions:
- optimizer-rewrite found no optimizer/rewrite, semantic-equivalence, parallel join, or aggregate-path issue.
- tests-session-config proposed TSC-1; I independently verified and accepted it as MAIN-1, now submitted as the inline comment.
- Convergence round 2 ended with both live subagents replying NO_NEW_VALUABLE_FINDINGS for the corrected RIGHT-side line 836 anchor after the misplaced position-based comment was deleted.
| assertTrue(Math.abs(with_index_size - another_with_index_size) | ||
| <= 0.1 * Math.max(with_index_size, another_with_index_size), | ||
| "index size mismatch beyond 10% tolerance: with_index=${with_index_size}, without_index=${another_with_index_size}") | ||
| assert_documents_show_data_size_in_range.call(with_index_size, "documents table with inverted index compaction") |
There was a problem hiding this comment.
This drops the actual comparison between the compaction-enabled and compaction-disabled paths. The suite deliberately builds one table with inverted_index_compaction_enable=true and another with it false, but after this change both values are only checked against broad independent ranges. For example, in cloud mode 55 KB and 70 KB would both pass even though the two paths differ by more than 20%, so a regression in compaction size accounting could slip through. Please keep the absolute sanity range if needed, but also retain a relative comparison between with_index_size and another_with_index_size.
Summary
test_show_data_with_compactionso it no longer compares physicalSHOW DATAsizes exactly after full compaction.Testing
git diff --check -- regression-test/suites/inverted_index_p2/test_show_data.groovy./run-regression-test.sh --run -d inverted_index_p2 -s test_show_data_with_compaction -parallel 1