[fix](test) Stabilize export parallelism CSV reload#65395
Open
shuke987 wants to merge 1 commit into
Open
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
Collaborator
Author
|
/review |
Contributor
There was a problem hiding this comment.
Review opinion: no blocking issue found.
I reviewed PR 65395 at head 22eb45f. The PR changes only regression-test/suites/export_p2/test_export_with_parallelism.groovy.
Critical checkpoint conclusions:
- Goal and proof: the change is a test stabilization for export parallelism reloads. The per-export UUID S3 prefix prevents stale files from previous formats/runs from being matched, and the CSV-family reloads now pass the TVF schema needed for stable typed reads. The existing generated
.outfile still has result blocks matching the suite's invocations. - Scope and clarity: the patch is small and localized to the affected regression suite.
- Concurrency: no production concurrency path is changed. For the test, using a UUID-specific object prefix reduces cross-run/object collision risk.
- Lifecycle/static initialization: not applicable; no lifecycle or static initialization code changes.
- Configuration/session propagation: no new config is added. The existing Nereids session setup is unchanged. The added CSV TVF properties are local to the reload query and only applied to CSV-family formats.
- Compatibility/storage/protocol: not applicable; no production serialization, storage, or FE-BE protocol change.
- Parallel code paths: csv, parquet, orc, csv_with_names, and csv_with_names_and_types paths were checked. The CSV header formats still rely on their existing header-skip behavior, with
csv_schemaonly stabilizing TVF column typing. - Special conditions: the
format in ["csv", "csv_with_names", "csv_with_names_and_types"]condition matches the formats that need CSV TVF schema and separator properties. - Test coverage/results: this is itself a regression-test change. The expected output file is not changed, and the output block count remains consistent with the 21 reload checks plus the initial source-table check.
- Observability: no additional observability is needed for this test-only change.
- Transaction/persistence/data writes: no production transaction or persistence path is changed.
- FE-BE variables/performance: no new transmitted variable or performance-sensitive production path is changed.
User focus points: none were provided beyond the full PR review.
Subagent conclusions:
optimizer-rewrite: no optimizer/rewrite, semantic-equivalence, parallel join, or aggregate-path issue found.tests-session-config: no regression/session/config/CI issue found.- Final convergence round 1 ended with both live subagents replying
NO_NEW_VALUABLE_FINDINGSfor the same current ledger and empty proposed final comment set.
Validation limits: static review only. This checkout is missing .worktree_initialized, thirdparty/installed, and thirdparty/installed/bin/protoc, so I did not run the S3 regression suite locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing