FINERACT-2293: New command processing - create client address by nidhiii128 · Pull Request #6049 · apache/fineract

nidhiii128 · 2026-06-27T12:01:04Z

JIRA: https://issues.apache.org/jira/browse/FINERACT-2293

Migrates the create client address endpoint (POST /v1/client/{clientId}/addresses?type={addressTypeId})
from the legacy JsonCommand command-processing path to the new typed fineract-command framework.

Scope (PR 1 of 2 for FINERACT-2293)

New typed AddressCreateRequest / AddressCreateResponse POJOs with Jakarta Validation
New AddressMapper (MapStruct) — no JsonObject in the new code path
New AddressDomainService / AddressDomainServiceImpl — typed write service following the
template module (FINERACT-2564) pattern
New AddressCreateCommand / AddressCreateCommandHandler using CommandHandler<REQ, RES>
Controller routes through CommandDispatcher and returns AddressCreateResponse directly
AntMatcher added in SecurityConfig for POST /api//client//addresses (CREATE_ADDRESS)
Resilience4j retry config for commandAddressCreate
Validation message bundle entries added
Legacy AddClientAddressCommandHandler deleted
Legacy addClientAddress(Long, Long, JsonCommand) method removed from
AddressWritePlatformService (no remaining callers)
Legacy CommandWrapperBuilder.addClientAddress(Long, Long) builder method removed

addNewClientAddress(Client, JsonCommand) kept on AddressWritePlatformService since it is
still called by the client creation flow (ClientWritePlatformServiceJpaRepositoryImpl).
That migration is out of scope here.

Pattern follows the merged template-module reference (#5851).

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

Write the commit message as per our guidelines
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow our coding conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

adamsaghy · 2026-06-29T13:17:43Z

* What went wrong:
Execution failed for task ':integration-tests:compileTestJava'.
> Compilation failed; see the compiler output below.
  /home/runner/work/fineract/fineract/integration-tests/src/test/java/org/apache/fineract/integrationtests/SmsCampaignIntegrationTest.java:66: warning: [removal] initializeRESTAssured() in Utils has been deprecated and marked for removal
          Utils.initializeRESTAssured();
               ^
  2 errors

Please run:
./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest
./gradlew --no-daemon build -x test -x cucumber -x doc

Before any PR or changes, please always run these two commands and make sure there is green build!

Aman-Mittal · 2026-07-03T09:57:03Z

@adamsaghy @vidakovic please review

vidakovic · 2026-07-07T16:14:11Z

    }

-    public CommandWrapperBuilder addClientAddress(final long clientId, final long addressTypeId) {
+    public CommandWrapperBuilder addClientAddress(final Long clientId, final Long addressTypeId) {


Why do we need this when we migrate to new command processing?

vidakovic · 2026-07-07T16:15:56Z


-    CommandProcessingResult addClientAddress(Long clientId, Long addressTypeId, JsonCommand command);
-
    CommandProcessingResult addNewClientAddress(Client client, JsonCommand command);


Nope, belongs to legacy command processing.

vidakovic · 2026-07-07T16:16:02Z

-
    CommandProcessingResult addNewClientAddress(Client client, JsonCommand command);

    CommandProcessingResult updateClientAddress(Long clientId, JsonCommand command);


Nope, belongs to legacy command processing.

vidakovic · 2026-07-07T16:16:29Z

@@ -53,27 +53,6 @@ public class AddressWritePlatformServiceImpl implements AddressWritePlatformServ
    private final ClientAddressRepositoryWrapper clientAddressRepositoryWrapper;
    private final AddressCommandFromApiJsonDeserializer fromApiJsonDeserializer;


Nope, manual JSON parsing. We want to get away from this.

vidakovic · 2026-07-07T16:16:38Z

-    }
-
    @Override
    public CommandProcessingResult addNewClientAddress(final Client client, final JsonCommand command) {


Nope, belongs to legacy command processing.

vidakovic · 2026-07-07T16:17:22Z

+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+@ExtendWith(MockitoExtension.class)


Same comment as in the PR #6085 concerning testing.

vidakovic · 2026-07-07T16:18:33Z

@@ -265,14 +264,14 @@ public static PostClientsResponse createClient(final RequestSpecification reques
    // Example: org.apache.fineract.integrationtests.common.loans.LoanTransactionHelper.disburseLoan(java.lang.Long,
    // org.apache.fineract.client.models.PostLoansLoanIdRequest)
    @Deprecated(forRemoval = true)
-    public static PostClientClientIdAddressesResponse createClientAddress(final RequestSpecification requestSpec,
+    public static HashMap<String, Object> createClientAddress(final RequestSpecification requestSpec,


This looks wrong. We lost the type information and the whole idea of this code change is to have proper types in the first place. Something is wrong in the REST API resource class!

vidakovic · 2026-07-07T16:18:40Z

                .stateProvinceId(Long.valueOf(stateId)).isActive(addressIsActive);
-        PostClientClientIdAddressesResponse response = ClientHelper.createClientAddress(requestSpec, responseSpec, clientId.longValue(),
-                addressTypeId, request);
+        HashMap<String, Object> response = ClientHelper.createClientAddress(requestSpec, responseSpec, clientId.longValue(), addressTypeId,


This looks wrong. We lost the type information and the whole idea of this code change is to have proper types in the first place. Something is wrong in the REST API resource class!

nidhiii128 force-pushed the FINERACT-2293-create-client-address branch 2 times, most recently from da0273f to 54d08b9 Compare June 29, 2026 07:30

FINERACT-2293: New command processing - create client address

d064384

nidhiii128 force-pushed the FINERACT-2293-create-client-address branch from 54d08b9 to d064384 Compare June 30, 2026 12:37

Aman-Mittal assigned vidakovic Jul 3, 2026

nidhiii128 mentioned this pull request Jul 3, 2026

FINERACT-2293: update client address #6085

Draft

6 tasks

vidakovic reviewed Jul 7, 2026

View reviewed changes

nidhiii128 marked this pull request as draft July 10, 2026 07:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

FINERACT-2293: New command processing - create client address#6049

FINERACT-2293: New command processing - create client address#6049
nidhiii128 wants to merge 1 commit into
apache:developfrom
nidhiii128:FINERACT-2293-create-client-address

nidhiii128 commented Jun 27, 2026

Uh oh!

adamsaghy commented Jun 29, 2026

Uh oh!

Aman-Mittal commented Jul 3, 2026

Uh oh!

vidakovic Jul 7, 2026

Uh oh!

vidakovic Jul 7, 2026

Uh oh!

vidakovic Jul 7, 2026

Uh oh!

vidakovic Jul 7, 2026

Uh oh!

vidakovic Jul 7, 2026

Uh oh!

vidakovic Jul 7, 2026

Uh oh!

vidakovic Jul 7, 2026

Uh oh!

vidakovic Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		CommandProcessingResult addClientAddress(Long clientId, Long addressTypeId, JsonCommand command);

		CommandProcessingResult addNewClientAddress(Client client, JsonCommand command);


		CommandProcessingResult addNewClientAddress(Client client, JsonCommand command);

		CommandProcessingResult updateClientAddress(Long clientId, JsonCommand command);

		@@ -53,27 +53,6 @@ public class AddressWritePlatformServiceImpl implements AddressWritePlatformServ
		private final ClientAddressRepositoryWrapper clientAddressRepositoryWrapper;
		private final AddressCommandFromApiJsonDeserializer fromApiJsonDeserializer;

Uh oh!

Conversation

nidhiii128 commented Jun 27, 2026

Checklist

Uh oh!

adamsaghy commented Jun 29, 2026

Uh oh!

Aman-Mittal commented Jul 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants