[FLINK-39899] Fix Flink SQL rowtime attributes after Window TVF#28376
Open
shanzi wants to merge 3 commits into
Open
[FLINK-39899] Fix Flink SQL rowtime attributes after Window TVF#28376shanzi wants to merge 3 commits into
shanzi wants to merge 3 commits into
Conversation
Collaborator
…alizing the original time attribute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This MR is to fix FLINK-39899 which allows original rowtime keep to be rowtime attribute after Window TVF, where a new
window_timeis added as the correct rowtime attribute. This not only mismatches the original design in FLIP-145. ("The original row time attribute "timecol" will be a regular timestamp column after applying window TVF."), but also can lead to dropped results and incorrect result when misused.This change is to fix the issue: after Window TVF, only one rowtime attribute will be left.
Brief change log
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
This change added tests and can be verified as follows:
WindowTableFunctionTestis updated to verify the behavior.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code