FLINK-XXXXX: add GROUP BY <int literal>#28381
Open
tisyabhatia wants to merge 1 commit into
Open
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request adds initial support for positional references in the
GROUP BYclause (GROUP BY <n>) in Flink SQL. When enabled, an integer literalninGROUP BYrefers to the n-th expression in theSELECTlist.Because this changes the meaning of existing queries, the behavior is gated behind a new table config option that is disabled by default. It is intended to flip to true in a future release after a customer-notice period.
This feature requires no parser / grammar changes as Apache Calcite (
apache/calcite) already resolves group ordinals when itsSqlConformance.isGroupByOrdinal()returnstrue. Flink simply enables that resolution per the config flag by wrapping the validator's conformance, so Calcite's ordinal resolution and error handling are reused as-is.This work is backed by an internal design doc and a FLIP (currently under review).
Brief change log
table.group-by-ordinal-enabled(defaultfalse) gating the behaviorFlinkCalciteSqlValidatorsoisGroupByOrdinal()returnstrueonly when the option is enabled, reusing Calcite's native group-ordinal resolutionGroupByOrdinalTestVerifying this change
This change added tests and can be verified as follows:
GroupByOrdinalTest(parametrized: ordinal -> column, multiple ordinals, ordinal mixed with explicit column, ordinal -> whole expression; plus the flag-off "literal stays a constant" case and out-of-range, zero-ordinal, and ordinal-points-at-an-aggregated errors)table.group-by-ordinal-enabledconfig option (off by default preserves existingGROUP BY <constant>semantics)Does this pull request potentially affect one of the following parts:
@Public(Evolving)API: noDocumentation
Was generative AI tooling used to co-author this PR? Yes - Generated-by: Claude Code