[FLINK-35012][table] Fix flaky ChangelogNormalizeRestoreTest by adding padding records to prevent mini-batch merging#28382
Open
Au-Miner wants to merge 1 commit into
Open
[FLINK-35012][table] Fix flaky ChangelogNormalizeRestoreTest by adding padding records to prevent mini-batch merging#28382Au-Miner wants to merge 1 commit into
Au-Miner wants to merge 1 commit into
Conversation
…g padding records to prevent mini-batch merging
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix the flaky
ChangelogNormalizeRestoreTest.testRestorefailure for thechangelog-normalize-source-mini-batchvariant. The test intermittently fails becauseINSERT "six"andDELETE "six"can end up in the same mini-batch, causingaddInputto overwrite the INSERT with the DELETE, resulting in both records being silently dropped.Brief change log
DELETEpadding record ("seven") toAFTER_DATAto ensureINSERT "six"andDELETE "six"are always separated into different mini-batches byCountBundleTrigger(size=2), regardless of processing-time watermark timing.Verifying this change
This change is a test-only fix. The existing
ChangelogNormalizeRestoreTest.testRestoretest validates correctness. The padding DELETE records target non-existent keys, so they produce no output and do not affectAFTER_OUTPUTexpectations.Does this pull request potentially affect one of the following parts
@Public(Evolving): noDocumentation