Skip to content

[FLINK-35012][table] Fix flaky ChangelogNormalizeRestoreTest by adding padding records to prevent mini-batch merging#28382

Open
Au-Miner wants to merge 1 commit into
apache:masterfrom
Au-Miner:FLINK-35012
Open

[FLINK-35012][table] Fix flaky ChangelogNormalizeRestoreTest by adding padding records to prevent mini-batch merging#28382
Au-Miner wants to merge 1 commit into
apache:masterfrom
Au-Miner:FLINK-35012

Conversation

@Au-Miner

Copy link
Copy Markdown
Contributor

What is the purpose of the change

Fix the flaky ChangelogNormalizeRestoreTest.testRestore failure for the changelog-normalize-source-mini-batch variant. The test intermittently fails because INSERT "six" and DELETE "six" can end up in the same mini-batch, causing addInput to overwrite the INSERT with the DELETE, resulting in both records being silently dropped.

Brief change log

  • [ChangelogNormalizeTestPrograms.java] Added one no-op DELETE padding record ("seven") to AFTER_DATA to ensure INSERT "six" and DELETE "six" are always separated into different mini-batches by CountBundleTrigger(size=2), regardless of processing-time watermark timing.

Verifying this change

This change is a test-only fix. The existing ChangelogNormalizeRestoreTest.testRestore test validates correctness. The padding DELETE records target non-existent keys, so they produce no output and do not affect AFTER_OUTPUT expectations.

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Currentity, Coordination, Zookeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

…g padding records to prevent mini-batch merging
@flinkbot

flinkbot commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants