[FLINK-35230][table] Split FlinkSqlParserImplTest into smaller test classes#28387
Open
Au-Miner wants to merge 1 commit into
Open
[FLINK-35230][table] Split FlinkSqlParserImplTest into smaller test classes#28387Au-Miner wants to merge 1 commit into
Au-Miner wants to merge 1 commit into
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Split the monolithic
FlinkSqlParserImplTest(4000+ lines) into smaller, focused test classes to improve maintainability and eliminate the CheckstyleFileLengthsuppression.Brief change log
FlinkSqlParserTestBaseas a shared base class providingfixture(),sql(),expr(),validated()methodsCatalogTest,MetadataTest,CreateTableTest,AlterTableTest,CtasTest,ViewTest,ModelTest,ConnectionTest,ExecuteTest,MiscTestFlinkSqlParserCalciteTestextendingSqlParserTestto restore Calcite standard SQL test coverage (472 inherited tests)FlinkSqlParserUnParserTestusing JUnit 5@Nestedinner classesFlinkSqlParserImplTestFileLengthsuppression fromsuppressions.xmlVerifying this change
This is a pure refactoring — 248 Flink-specific test methods before and after, verified via
diffon extracted method names. The 472 inherited Calcite tests are now covered byFlinkSqlParserCalciteTest.Does this pull request potentially affect one of the following parts
@Public(Evolving): noDocumentation