[FLINK-39915][table] Reject mixing positional and named function arguments#28399
Open
gustavodemorais wants to merge 2 commits into
Open
[FLINK-39915][table] Reject mixing positional and named function arguments#28399gustavodemorais wants to merge 2 commits into
gustavodemorais wants to merge 2 commits into
Conversation
Collaborator
raminqaf
approved these changes
Jun 12, 2026
raminqaf
left a comment
raminqaf
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for the fix!
fhueske
reviewed
Jun 12, 2026
fhueske
left a comment
fhueske
left a comment
Contributor
There was a problem hiding this comment.
The change looks good, but I'd add two more assertions to the test.
Cheers, Fabian
|
|
||
| @Test | ||
| void testMixedPositionalAndNamedArguments() { | ||
| assertThatThrownBy(() -> plannerMocks.getParser().parse("SELECT myFunc(1, b => 2) FROM t1")) |
Contributor
There was a problem hiding this comment.
add assertions that all positional and all named do not throw?
github-actions
Bot
added
the
community-reviewed
…ll-named arguments
fhueske
approved these changes
Jun 12, 2026
fhueske
left a comment
fhueske
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix.
+1 to merge 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Calling a function with a mix of positional and named arguments (e.g.
f(TABLE t, op => DESCRIPTOR(x))) previously failed validation with an internal assertion calcite error. This surfaces a clear ValidationException instead, telling the user to use either all positional or all named arguments.Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?
2.1.117 (Claude Code) and Opus 4.8