[Flink-39911][historyserver] Support Pluggable Storage Backend for HistoryServer#28402
Open
chenzihao5 wants to merge 4 commits into
Open
[Flink-39911][historyserver] Support Pluggable Storage Backend for HistoryServer#28402chenzihao5 wants to merge 4 commits into
chenzihao5 wants to merge 4 commits into
Conversation
… FileArchiveStorage implementation
…m HistoryServerStaticFileServerHandler
Collaborator
reswqa
reviewed
Jun 12, 2026
reswqa
left a comment
reswqa
left a comment
Member
There was a problem hiding this comment.
Thanks @chenzihao5 for improving history server.
I made a rough scan first and left some comments.
| * | ||
| * @param <T> Type of the storage entries. | ||
| */ | ||
| public interface ArchiveStorage<T> extends Closeable { |
Member
There was a problem hiding this comment.
extends Closeable should be moved to the first commit.
Comment on lines
+155
to
+157
| if (keyPrefix == null || keyPrefix.isEmpty()) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (keyPrefix == null || keyPrefix.isEmpty()) { | |
| return; | |
| } | |
| if(StringUtils.isNullOrWhitespaceOnly(keyPrefix)) return; |
| * | ||
| * <p>Such as deleting all archived files for a given job or application. | ||
| * | ||
| * @param keyPrefix key prefix; should end with a separator (e.g. {@code "/"}) when the intent |
Member
There was a problem hiding this comment.
I don't think it is reasonable to introduce such constraints in the interface. Delete all entries with key prefix is well-defined in itself. We should not impose any hidden burden on the interface caller.
| * is to delete all entries under a logical directory | ||
| * @throws IOException if entries cannot be deleted | ||
| */ | ||
| void deletePrefix(String keyPrefix) throws IOException; |
Member
There was a problem hiding this comment.
Suggested change
| void deletePrefix(String keyPrefix) throws IOException; | |
| void deleteByPrefix(String keyPrefix) throws IOException; |
Comment on lines
+88
to
+89
| * @param prefix storage key prefix; should end with a separator (e.g. {@code "/"}) when the | ||
| * intent is to list all entries under a logical directory |
|
|
||
| /** Compression type used for the bottommost level of the RocksDB SST files. */ | ||
| public static final ConfigOption<String> HISTORY_SERVER_ARCHIVE_ROCKSDB_BOTTOMMOST_COMPRESSION = | ||
| key("historyserver.archive.rocksdb.bottommost-compression") |
Member
There was a problem hiding this comment.
Could we use enum type rather than String here?
Comment on lines
+315
to
+318
| if (!success) { | ||
| LOG.debug("Unable to load requested resource {} from classloader", requestPath); | ||
| throw new NotFoundException("Resource not found."); | ||
| } |
Member
There was a problem hiding this comment.
Why these code have to execute in finally block?
Comment on lines
71
to
72
| private final File webApplicationDir; | ||
| private final File webApplicationsOverviewDir; |
Member
There was a problem hiding this comment.
Could this two fields be local variable?
| * ArchiveRetainedStrategy} and {@link HistoryServerOptions#HISTORY_SERVER_CLEANUP_EXPIRED_JOBS}. | ||
| */ | ||
| class HistoryServerArchiveFetcher { | ||
| public class HistoryServerArchiveFetcher { |
Member
There was a problem hiding this comment.
Could we introduce generic type param for this fetch class?
| * @throws IOException if the entry cannot be read | ||
| */ | ||
| @Nullable | ||
| T get(String key) throws IOException; |
Member
There was a problem hiding this comment.
This is not a well-defined protocol as "put" and "get" method is not symmetrical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request introduces a pluggable archive storage backend for the HistoryServer, so that downloaded job archives no longer have to be unpacked into a large number of small JSON files on the local filesystem. And this PR adds a RocksDB backend that stores all archive entries as key-value pairs inside a single embedded RocksDB instance, while keeping the existing FILE backend as the default to preserve backwards compatibility.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?