[FLINK-39913][table] Improve the error message when a foreground query emits an upsert changelog#28403
Open
raminqaf wants to merge 1 commit into
Open
[FLINK-39913][table] Improve the error message when a foreground query emits an upsert changelog#28403raminqaf wants to merge 1 commit into
raminqaf wants to merge 1 commit into
Conversation
Collaborator
bd7e0fa to
480139a
Compare
…y emits an upsert changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
A foreground query (a bare
SELECTcollected through the anonymous result sink, which has no primary key) over a relation that emits an upsert changelog fails with an unhelpful error: Can't generate a valid execution plan for the given query followed by the optimized plan. A common trigger isFROM_CHANGELOGwithPARTITION BYand anop_mappingwithoutUPDATE_BEFORE. This change appends actionable guidance to that error. Behavior is unchanged; only the message is improved.Brief change log
FlinkChangelogModeInferenceProgram: when the rejected plan involves updates, append guidance explaining the upsert-vs-retract mismatch and the two fixes (declare aPRIMARY KEYon the sink, or make the upstream emitUPDATE_BEFORE). Gated onModifyKind.UPDATEso unrelated planning failures keep the original message.Verifiying the output
Locally setup a test and verified the exception message. The plan now includes the changelog mode of the operators. Before, it was all set to
NONE.Does this pull request potentially affect one of the following parts:
@Public(Evolving)API: noDocumentation